Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override SAP BTP service operator ConfigMap values during reconciliation #752

Open
2 tasks
szwedm opened this issue Jul 9, 2024 · 1 comment
Open
2 tasks
Labels
kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature

Comments

@szwedm
Copy link
Contributor

szwedm commented Jul 9, 2024

Use values from:
https://github.com/kyma-project/btp-manager/blob/557b078a6c2fcd33ca9affcde18e5cc55f5a7f5d/examples/btp-operator-configmap.yaml
which are stored in BTP Manager's controller as vars:


to override values in the ConfigMap:
https://github.com/kyma-project/btp-manager/blob/557b078a6c2fcd33ca9affcde18e5cc55f5a7f5d/module-resources/apply/configmap.yml

AC

  • 1) with this feature we will be able to set ENABLE_LIMITED_CACHE to true for selected Kyma clusters
  • 2) Enhance e2e tests with real credentials, when default namespace has own secret credentials (could be dummy). Then test creates SI in the default namespace and should fail (cause dummy secret), if it will work it will mean that there is a BUG in the sap-btp-service-operator because it has used secret from managed namespace from kyma-system
@szwedm szwedm added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jul 9, 2024
@PK85
Copy link
Contributor

PK85 commented Jul 11, 2024

We need to decide if we should start to expose some params in the BTPOperator CR or in this internal CM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants