Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proposal for Cluster CR we expect from KEB #125

Closed
5 tasks done
Tracked by #112 ...
tobiscr opened this issue Jan 16, 2024 · 2 comments
Closed
5 tasks done
Tracked by #112 ...

Create proposal for Cluster CR we expect from KEB #125

tobiscr opened this issue Jan 16, 2024 · 2 comments
Assignees

Comments

@tobiscr
Copy link
Contributor

tobiscr commented Jan 16, 2024

Description

The technical contract between the KEB and the KIM will be based on Cluster CR. As consumer of this resource, we have to come up with a proposal of the mandatory data which are required for this CR.

Consider also coming features and coming new requirements. We should be able to extend the model in a way that new features can be easily introduced into the structure without having a need to change already exiting fields.

Fields which are not dynamic and can be determined by the KIM should not be part of the CRD but instead land in the KIM configuration and be handled by KIM's logic.

Planned new features are:

AC:

  • Review a generated Gardener Shoot-Spec and extract all mandatory values we have to receive from KEB
  • Define an initial draft for a Cluster CRD
  • Share the CRD with Gophers in a call and explain what the purpose of the different fields is (only if they are not already self-explaining)

Relates to
#127

@PK85
Copy link

PK85 commented Jan 25, 2024

example what KEB sends/gets from provisioner:

"gardenerConfig": {
					"name": "c-77ac5ef",
					"kubernetesVersion": "1.27",
					"targetSecret": "gcp-skr-dev-cust-00001-e2e-test",
					"provider": "gcp",
					"region": "europe-west3",
					"seed": "gcp-ha-eu1",
					"machineType": "n2-standard-4",
					"machineImage": null,
					"machineImageVersion": null,
					"diskType": "pd-standard",
					"volumeSizeGB": 50,
					"workerCidr": "10.250.0.0/22",
					"podsCidr": null,
					"servicesCidr": null,
					"autoScalerMin": 3,
					"autoScalerMax": 20,
					"maxSurge": 3,
					"maxUnavailable": 0,
					"purpose": null,
					"licenceType": null,
					"enableKubernetesVersionAutoUpdate": null,
					"enableMachineImageVersionAutoUpdate": null,
					"providerSpecificConfig": {
						"zones": [
							"europe-west3-a",
							"europe-west3-b",
							"europe-west3-c"
						]
					},
					"dnsConfig": null,
					"oidcConfig": {
						"clientID": "9bd05ed7-a930-44e6-8c79-e6defeb7dec9",
						"groupsClaim": "groups",
						"issuerURL": "https://kymatest.accounts400.ondemand.com/",
						"signingAlgs": [
							"RS256"
						],
						"usernameClaim": "sub",
						"usernamePrefix": "-"
					},
					"exposureClassName": null,
					"shootNetworkingFilterDisabled": null,
					"controlPlaneFailureTolerance": null,
					"euAccess": null
				}

@Disper
Copy link
Member

Disper commented May 22, 2024

Closing, as the ADR was merged.

@Disper Disper closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants