Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Image Build and E2E Test Workflows #1943

Closed
2 tasks done
c-pius opened this issue Oct 8, 2024 · 0 comments · Fixed by kyma-project/runtime-watcher#405
Closed
2 tasks done

Split Image Build and E2E Test Workflows #1943

c-pius opened this issue Oct 8, 2024 · 0 comments · Fixed by kyma-project/runtime-watcher#405
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@c-pius
Copy link
Contributor

c-pius commented Oct 8, 2024

Description

Image build workflow now supports custom tags: kyma-project/test-infra#11981

This allows us to refactor our pipelines to get rid of the issue wrt. to pull_request_target. Proposal is to have two separate workflows:

  1. Triggers the image build and supplies the commit hash as custom tag
    • this workflow MUST continue to use pull_request_target as trigger (security requirement to get a GH token)
  2. Waits for the built image with the commit hash as custom tag, once there, starts the rest of the E2E test workflow
    • this workflow MUST use pull_request as trigger (e2e tests and setup should run in the up to date proposed config)

Reasons

Make our E2E tests work properly again

Acceptance Criteria

  • Each E2E test run uses an up to date image of the current PR ref
  • Each E2E test run executes test code of the current PR ref

Feature Testing

No response

Testing approach

No response

Attachments

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants