You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Find a way that notifies us when PRs to lifecycle-manager are likely requiring changes to management-plane-charts. For instance, changes to the configuration or the E2E test files (we used to have a github action that was comparing the make manifests" outcome between main head and PR). If there are changes, it is likely that we also need to modify something in management-plane-charts and the developer should double check.
Document what is expected from the assignee in case the above is triggered. E.g., extend the AC of the original issue to account for the changes in management-plane-charts, create a PR that is preparing and testing the required change and can serve as a base for the release manager to create the new release.
Reasons
Prevent delayed releases due to the release manager finding out too late that changes to the charts are needed.
Acceptance Criteria
Timeboxed to 1 day
approach identifying critical changes aligned and implemented
documentation available stating what should be done if so
Feature Testing
No response
Testing approach
No response
Attachments
No response
The text was updated successfully, but these errors were encountered:
File:.github/workflows/check-config-changes.yaml Purpose:
Detects changes in configuration files (e.g. under config/ and e2e/) on pull requests. If changes are detected, a warning comment is posted and a configs-changed label is applied.
Steps:
Get changed files: Lists and filters files changed in the PR.
Evaluate changes: Sets an output (config_changed) via GITHUB_OUTPUT.
Notify: Posts a comment and applies a label if changes exist.
2. Check Manifests Changes
File:.github/workflows/check-manifests-changes.yaml Purpose:
Generates manifests for both the PR and the main branch, compares them, and flags differences. If differences are detected, a warning comment and an outdated-manifests label are applied; otherwise, the label is safely removed.
Steps:
Generate & Cache: Runs manifest generation on both the PR and main branches.
Compare: Compares the cached manifests and sets an outdated_manifests output.
Notify & Manage Label: Posts a comment/adds a label if differences exist; otherwise, removes the label if present.
Changes on management-plane-chart
Refer to lifecycle-manager branch and changes needed files configs
-- kustomize into helm charts
Description
Find a way that notifies us when PRs to lifecycle-manager are likely requiring changes to management-plane-charts. For instance, changes to the configuration or the E2E test files (we used to have a github action that was comparing the make manifests" outcome between main head and PR). If there are changes, it is likely that we also need to modify something in management-plane-charts and the developer should double check.
Document what is expected from the assignee in case the above is triggered. E.g., extend the AC of the original issue to account for the changes in management-plane-charts, create a PR that is preparing and testing the required change and can serve as a base for the release manager to create the new release.
Reasons
Prevent delayed releases due to the release manager finding out too late that changes to the charts are needed.
Acceptance Criteria
Timeboxed to 1 day
Feature Testing
No response
Testing approach
No response
Attachments
No response
The text was updated successfully, but these errors were encountered: