Ensure istioNativeSidecars for all buildless git functions (#1770)

Author: kwiatekus

components/buildless-serverless/internal/controller/resources/deployment.go

@@ -21,7 +21,6 @@ const (
 	istioConfigLabelKey                      = "proxy.istio.io/config"
 	istioEnableHoldUntilProxyStartLabelValue = "{ \"holdApplicationUntilProxyStarts\": true }"
 	istioNativeSidecarLabelKey               = "sidecar.istio.io/nativeSidecar"
-	istioInjectSidecarLabelKey               = "sidecar.istio.io/inject"
 )
 
 type Deployment struct {
@@ -110,13 +109,11 @@ func (d *Deployment) currentAnnotationsWithoutPreviousFunctionAnnotations() map[
 	return result
 }
 
+// allow istio to inject native sidecar (istio-proxy as init container)
+// this is required for init container of git sourced functions to fetch source from git repository
 func (d *Deployment) annotationsRequiredByIstio() map[string]string {
 	result := make(map[string]string)
-
-	if d.function.HasGitSources() && d.function.HasLabel(istioInjectSidecarLabelKey, "true") {
-		result[istioNativeSidecarLabelKey] = "true"
-	}
-
+	result[istioNativeSidecarLabelKey] = "true"
 	return result
 }
 

components/buildless-serverless/internal/controller/resources/deployment_test.go

@@ -137,26 +137,16 @@ func TestDeployment_construct(t *testing.T) {
 
 		require.NotNil(t, r)
 		require.Equal(t, map[string]string{
-			"proxy.istio.io/config": "{ \"holdApplicationUntilProxyStarts\": true }",
-			"leavitt":               "hopeful",
-			"pike":                  "tender",
-			"thompson":              "exciting",
+			"proxy.istio.io/config":          "{ \"holdApplicationUntilProxyStarts\": true }",
+			"leavitt":                        "hopeful",
+			"pike":                           "tender",
+			"thompson":                       "exciting",
+			"sidecar.istio.io/nativeSidecar": "true",
 		}, r.Spec.Template.ObjectMeta.Annotations)
 	})
-	t.Run("enable native sidecar when istio is enabled and function has git repo", func(t *testing.T) {
+	t.Run("enable native sidecar", func(t *testing.T) {
 		d := minimalDeployment()
 
-		d.function.Spec.Source = serverlessv1alpha2.Source{
-			GitRepository: &serverlessv1alpha2.GitRepositorySource{
-				URL: "wonderful-germain",
-				Repository: serverlessv1alpha2.Repository{
-					BaseDir:   "recursing-mcnulty",
-					Reference: "epic-mendel"}}}
-
-		d.function.Spec.Labels = map[string]string{
-			"sidecar.istio.io/inject": "true",
-		}
-
 		r := d.construct()
 
 		require.NotNil(t, r)