From db337797c40182e4f700412e677696293aa77f2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Ma=C5=82achowski?= Date: Wed, 13 Nov 2024 11:39:18 +0100 Subject: [PATCH 1/3] Add description of Go internal modules --- cmd/image-builder/image-builder.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/cmd/image-builder/image-builder.md b/cmd/image-builder/image-builder.md index f8e39f991e0e..f7a2c5f4432b 100644 --- a/cmd/image-builder/image-builder.md +++ b/cmd/image-builder/image-builder.md @@ -165,4 +165,11 @@ The flag value is base64-encoded to avoid issues with special characters in the The `--env-file` specifies the path to the file with environment variables to be loaded in the build. All variables and their values are loaded into the environment before the build starts. -The file must be in the format of `KEY=VALUE` pairs, separated by newlines. \ No newline at end of file +The file must be in the format of `KEY=VALUE` pairs, separated by newlines. + +## Access Golang Internal Modules + +You can use Image Builder to build images that require access to Go internal modules. To use this feature, set the `--use-go-internal-modules=true` flag. +The feature is only available for the ADO backend. + +This feature utilize the `go` vendor mechanism by downloading all the dependencies into the `vendor` directory. There is no option to pass custom credentials for fetching the dependencies, the tool handles it internally. From 0d648b119fd40b6f67f3f712a9d6011639e2e00a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Ma=C5=82achowski?= <38684517+KacperMalachowski@users.noreply.github.com> Date: Thu, 14 Nov 2024 10:45:00 +0100 Subject: [PATCH 2/3] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Wojciech Sołtys <74361703+Sawthis@users.noreply.github.com> --- cmd/image-builder/image-builder.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/image-builder/image-builder.md b/cmd/image-builder/image-builder.md index f7a2c5f4432b..fb31d5d1e730 100644 --- a/cmd/image-builder/image-builder.md +++ b/cmd/image-builder/image-builder.md @@ -167,9 +167,9 @@ The `--env-file` specifies the path to the file with environment variables to be All variables and their values are loaded into the environment before the build starts. The file must be in the format of `KEY=VALUE` pairs, separated by newlines. -## Access Golang Internal Modules +## Access Golang SAP Internal Modules -You can use Image Builder to build images that require access to Go internal modules. To use this feature, set the `--use-go-internal-modules=true` flag. +You can use Image Builder to build images that require access to Go SAP internal modules. To use this feature, set the `--use-go-internal-sap-modules=true` flag. The feature is only available for the ADO backend. This feature utilize the `go` vendor mechanism by downloading all the dependencies into the `vendor` directory. There is no option to pass custom credentials for fetching the dependencies, the tool handles it internally. From 79fca90ff3debea0493dc3c16c000bc0dd62005e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wojciech=20So=C5=82tys?= <74361703+Sawthis@users.noreply.github.com> Date: Mon, 18 Nov 2024 08:08:23 +0100 Subject: [PATCH 3/3] Update cmd/image-builder/image-builder.md Co-authored-by: Iwona Langer --- cmd/image-builder/image-builder.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/image-builder/image-builder.md b/cmd/image-builder/image-builder.md index fb31d5d1e730..74cf84fd8bb2 100644 --- a/cmd/image-builder/image-builder.md +++ b/cmd/image-builder/image-builder.md @@ -172,4 +172,4 @@ The file must be in the format of `KEY=VALUE` pairs, separated by newlines. You can use Image Builder to build images that require access to Go SAP internal modules. To use this feature, set the `--use-go-internal-sap-modules=true` flag. The feature is only available for the ADO backend. -This feature utilize the `go` vendor mechanism by downloading all the dependencies into the `vendor` directory. There is no option to pass custom credentials for fetching the dependencies, the tool handles it internally. +This feature utilizes the `go` vendor mechanism by downloading all the dependencies into the `vendor` directory. There is no option to pass custom credentials for fetching the dependencies; the tool handles it internally.