-
Notifications
You must be signed in to change notification settings - Fork 2
/
ChangeLog
6832 lines (4957 loc) · 247 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
commit af6365a
Author: João Valverde <[email protected]>
Date: Sun Aug 30 23:18:34 2015 +0100
Allow "Decode As" for IPv6 over UDP
Change-Id: Ib28206e9573f1dd624be1d3c265fef405f65b19a
Reviewed-on: https://code.wireshark.org/review/10351
Reviewed-by: Alexis La Goutte <[email protected]>
Petri-Dish: Alexis La Goutte <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Michael Mann <[email protected]>
commit d512710
Author: Dario Lombardo <[email protected]>
Date: Wed Sep 2 13:40:46 2015 +0200
idl2wrs: fix clang analyzer Warning complains.
890:9: warning: Access to field 'str' results in a dereference of a null pointer (loaded from variable 'token_list')
3132:4: warning: Value stored to 'str' is never read
3155:4: warning: Value stored to 'str' is never read
3166:4: warning: Value stored to 'str' is never read
3183:4: warning: Value stored to 'str' is never read
3192:4: warning: Value stored to 'str' is never read
3203:4: warning: Value stored to 'str' is never read
3220:4: warning: Value stored to 'str' is never read
Change-Id: If1a1acfc331e0648f95f6d6defe6533b6927ccaa
Reviewed-on: https://code.wireshark.org/review/10357
Reviewed-by: Alexis La Goutte <[email protected]>
commit 5518ae0
Author: Pascal Quantin <[email protected]>
Date: Wed Sep 2 12:43:23 2015 +0200
PER: followup of g59453fb
Change-Id: I45c02a249444e5f17d99eeb0ca8dea6f7a012262
Reviewed-on: https://code.wireshark.org/review/10356
Reviewed-by: Pascal Quantin <[email protected]>
Petri-Dish: Pascal Quantin <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Alexis La Goutte <[email protected]>
commit e1dee7c
Author: Dario Lombardo <[email protected]>
Date: Wed Sep 2 12:27:31 2015 +0200
dcerpc: fixed distcheck.
Change-Id: Ide0b95278786d45d9c41fb0fe3214dce0880b830
Reviewed-on: https://code.wireshark.org/review/10355
Reviewed-by: Alexis La Goutte <[email protected]>
commit 5d8363e
Author: Tom Haynes <[email protected]>
Date: Tue Sep 1 14:07:30 2015 -0700
nfs: Fix order of octets in IPv4 address
Before:
skull:bugs loghyr$ ~/ipv4/wireshark/tshark -r 2-layoutstats-in-1-compound.pcap -Y nfs -V | grep -i ipv4
[IPv4 address 113.12.31.172, protocol=tcp, port=2049]
After:
skull:bugs loghyr$ ~/ipv4/wireshark/tshark -r 2-layoutstats-in-1-compound.pcap -Y nfs -V | grep -i ipv4
[IPv4 address 172.31.12.113, protocol=tcp, port=2049]
Bug: 11496
Change-Id: Ia6097ae76411f6ff9de1f53191c8fc767856e2d1
Signed-off-by: Tom Haynes <[email protected]>
Reviewed-on: https://code.wireshark.org/review/10347
Petri-Dish: Pascal Quantin <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Pascal Quantin <[email protected]>
commit 920e056
Author: Alexis La Goutte <[email protected]>
Date: Wed Sep 2 07:48:34 2015 +0200
idl2wrs: Make Mac OSX buildbot happy
Change-Id: I5f9c860bec0f8d323d9f3cd7cf55e348654c8b8b
Reviewed-on: https://code.wireshark.org/review/10354
Reviewed-by: Alexis La Goutte <[email protected]>
commit 8b6fe35
Author: João Valverde <[email protected]>
Date: Wed Sep 2 01:33:22 2015 +0100
IPv4: Remove extraneous colon from format string
Change-Id: If52f8086ec971cc43947ece3d8e062da8378fa95
Reviewed-on: https://code.wireshark.org/review/10352
Reviewed-by: Alexis La Goutte <[email protected]>
commit 59453fb
Author: Michael Mann <[email protected]>
Date: Tue Sep 1 22:14:47 2015 -0400
Eliminate proto_tree_add_text from packet-per.c
Change-Id: I67f572129821fb00e4478a30bfd4a52287b8b1a1
Reviewed-on: https://code.wireshark.org/review/10350
Petri-Dish: Michael Mann <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Alexis La Goutte <[email protected]>
commit c41a833
Author: Michael Mann <[email protected]>
Date: Tue Sep 1 20:18:15 2015 -0400
Eliminate proto_tree_add_text from some dissectors.
Change-Id: If617016f588bbf940f37699e27559dc5c59cf508
Reviewed-on: https://code.wireshark.org/review/10349
Reviewed-by: Michael Mann <[email protected]>
Petri-Dish: Michael Mann <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Alexis La Goutte <[email protected]>
commit 630f48f
Author: Michael Mann <[email protected]>
Date: Tue Sep 1 13:28:56 2015 -0400
Eliminate proto_tree_add_text from packet-rsvp.c
Change-Id: I95edc1b40c07a4addf194df6a2056e7b61193e5a
Reviewed-on: https://code.wireshark.org/review/10348
Reviewed-by: Michael Mann <[email protected]>
Petri-Dish: Michael Mann <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Alexis La Goutte <[email protected]>
commit 87f2bd4
Author: Dario Lombardo <[email protected]>
Date: Fri Aug 14 12:02:38 2015 +0200
idl2wrs: some code cleanups.
Code cleanups include:
- sanity checks for malloc()
- change forbidden APIs into g_* versions
- minor indentation fixes
- add modeline
- add compilation for cmake and autotools
Bug: 11052
Change-Id: I825f04d9703448f9165d188be2bdd185fce5ff5d
Reviewed-on: https://code.wireshark.org/review/10030
Petri-Dish: Alexis La Goutte <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Alexis La Goutte <[email protected]>
Reviewed-by: Michael Mann <[email protected]>
commit aa1f556
Author: Alexis La Goutte <[email protected]>
Date: Mon Aug 31 13:59:28 2015 +0200
MSDP: fix will never be executed [-Wunreachable-code]
Move tvbuff declaration for avoid https://llvm.org/bugs/show_bug.cgi?id=19020
Found by Clang 3.7
Change-Id: I299d2413dc4effc5e6e34c289152b8f401f19342
Reviewed-on: https://code.wireshark.org/review/10326
Reviewed-by: Alexis La Goutte <[email protected]>
Reviewed-by: Michael Mann <[email protected]>
commit 998dcc2
Author: Alexis La Goutte <[email protected]>
Date: Tue Sep 1 19:50:52 2015 +0200
ANSI: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
Change-Id: I981336271a8f6b41fe777f732069639df494c5d2
Reviewed-on: https://code.wireshark.org/review/10346
Reviewed-by: Pascal Quantin <[email protected]>
Reviewed-by: Michael Mann <[email protected]>
commit b7764fc
Author: Alexis La Goutte <[email protected]>
Date: Mon Aug 31 14:01:46 2015 +0200
UMTS (mac): fix will never be executed [-Wunreachable-code]
Move tvbuff_t declaration for avoid https://llvm.org/bugs/show_bug.cgi?id=19020
Found by Clang 3.7
Change-Id: Id26fd62273d6838774db161a8b3f6c7db94a2de1
Reviewed-on: https://code.wireshark.org/review/10328
Reviewed-by: Alexis La Goutte <[email protected]>
Reviewed-by: Michael Mann <[email protected]>
commit c8f8784
Author: Pascal Quantin <[email protected]>
Date: Tue Sep 1 19:39:44 2015 +0200
ANSI A: fix dissection of numerous fields broken in g7298a31
Change-Id: I09898cfc1aedc4b8067c6d12c94effc51a5ebbc0
Reviewed-on: https://code.wireshark.org/review/10345
Petri-Dish: Pascal Quantin <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Pascal Quantin <[email protected]>
commit f0e4c49
Author: Gerald Combs <[email protected]>
Date: Tue Sep 1 08:24:58 2015 -0700
Update the release notes.
Change-Id: I0ab4cc92c24048e4e77b12bcc205d7a15a5ddb74
Reviewed-on: https://code.wireshark.org/review/10343
Reviewed-by: Alexis La Goutte <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit db2fdfd
Author: Gerald Combs <[email protected]>
Date: Tue Sep 1 07:37:45 2015 -0700
Fixup the main window tab order.
Make sure the packet list is directly after the display filter edit in
the main window tab order. When we press enter in the display filter
edit, go to the next child in the tab order.
Change-Id: If46e178365dbd59feb5985e9f8fa8b55d004d864
Reviewed-on: https://code.wireshark.org/review/10342
Reviewed-by: Gerald Combs <[email protected]>
commit a8682af
Author: AndersBroman <[email protected]>
Date: Tue Sep 1 09:53:38 2015 +0200
[mtp3_summary_dialog] Unused parameter warning with MSVC
mtp3_summary_dialog.cpp(315) : warning C4100: 'edt' : unreferenced formal para
mtp3_summary_dialog.cpp(314) : warning C4100: 'pinfo' -
Change-Id: Ia21e15ff6348f34bf8ae240f867f0ab2cade606a
Reviewed-on: https://code.wireshark.org/review/10340
Reviewed-by: Anders Broman <[email protected]>
commit 7298a31
Author: Michael Mann <[email protected]>
Date: Mon Aug 31 00:20:49 2015 -0400
Eliminate proto_tree_add_text from ANSI dissectors.
Change-Id: I22dccb2f2d71897334e11632f4060ccfbf4794ad
Reviewed-on: https://code.wireshark.org/review/10334
Petri-Dish: Michael Mann <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Anders Broman <[email protected]>
commit 54d2ff1
Author: Gerald Combs <[email protected]>
Date: Mon Aug 31 16:06:33 2015 -0700
Convert the WSP stats to generic stat API.
Add support for multiple tables to SimpleStatisticsDialog.
Change-Id: I843d901db092d2f2856d3d1a16f29f85fb41374b
Reviewed-on: https://code.wireshark.org/review/10339
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit 377d215
Author: Gerald Combs <[email protected]>
Date: Mon Aug 31 12:24:48 2015 -0700
Convert the MTP3 stats to new "generic stat API".
Convert both the MTP3 statistics and summary. As with the GSM stats this
is mostly untested.
Change-Id: I7af8d5f21c8161dc95f7f2c710f32364b6f6a431
Reviewed-on: https://code.wireshark.org/review/10338
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit e9614ad
Author: Pascal Quantin <[email protected]>
Date: Mon Aug 31 12:19:34 2015 +0200
Windows: update GeoIP library to 1.6.6
Change-Id: I56f58e52fa39fdddd35bcc7ef6d96cfa4042892d
Reviewed-on: https://code.wireshark.org/review/10333
Petri-Dish: Pascal Quantin <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Anders Broman <[email protected]>
commit 1772416
Author: Pascal Quantin <[email protected]>
Date: Mon Aug 31 22:10:23 2015 +0200
tshark.pod: fix typo
Change-Id: Iba5f12637e0f494805f2d9aab370fb42a32c1cb9
Reviewed-on: https://code.wireshark.org/review/10335
Reviewed-by: Pascal Quantin <[email protected]>
commit 4e236e6
Author: Stig Bjørlykke <[email protected]>
Date: Sat Aug 29 22:59:00 2015 +0200
Qt/Lua: Call atclose when TextWindow closes
The close callback was never called because the destructor was never called.
Change-Id: I9f6204858bc5d5e48d0aedc90b0e242ab70e161c
Reviewed-on: https://code.wireshark.org/review/10321
Reviewed-by: Stig Bjørlykke <[email protected]>
commit 7dd8349
Author: Alexis La Goutte <[email protected]>
Date: Wed Aug 12 20:58:52 2015 +0200
NGHTTP2: Update to 1.3.0
Change-Id: Ia12396b3b4a2bb4dcbdce63d06558b6474cd588e
Reviewed-on: https://code.wireshark.org/review/10324
Petri-Dish: Alexis La Goutte <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Alexis La Goutte <[email protected]>
commit 026812c
Author: Gerald Combs <[email protected]>
Date: Mon Aug 31 08:37:15 2015 -0700
Redraw timestamps when time display settings change.
As with g3bec655, we need to call columnsChanged (which invalidates
cached column strings) whenever any settings that generate those strings
change. Do so for the time display preferences in the View menu.
Bug: 11429
Change-Id: I71bf1cc0df2800902ecb7b734b8f12ebd85a4de5
Reviewed-on: https://code.wireshark.org/review/10331
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit 75b8457
Author: Gerald Combs <[email protected]>
Date: Mon Aug 31 09:24:49 2015 -0700
Add a Telephony→SCTP submenu.
Add the current SCTP actions to the telephony menu to match the GTK+ UI.
Change-Id: Ie7471bcbd1a82fe3f203d60f5ea8a72d923f34b9
Reviewed-on: https://code.wireshark.org/review/10332
Reviewed-by: Gerald Combs <[email protected]>
commit 3bec655
Author: Gerald Combs <[email protected]>
Date: Fri Aug 28 16:46:17 2015 -0700
Redraw the packet list when name resolution changes.
Call columnsChanged (which invalidates cached column strings) when we
change our name resolution preferences from the View menu.
Remove the last sorted column tracking from gf19a173 while we're here
(it didn't work properly).
Bug: 11468
Change-Id: I7fea58d702b283028235d023f27ab0336d8643a4
Reviewed-on: https://code.wireshark.org/review/10301
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit a060183
Author: Michael Mann <[email protected]>
Date: Fri Aug 28 22:41:07 2015 -0400
Eliminate proto_tree_add_text from packet-rtps.c
Change-Id: I353b4fcb3091e731a4b2a68e1932a5abc60c6038
Reviewed-on: https://code.wireshark.org/review/10323
Petri-Dish: Michael Mann <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Anders Broman <[email protected]>
commit 053f53c
Author: Joerg Mayer <[email protected]>
Date: Mon Aug 31 06:00:28 2015 +0400
Add a hidden item that allows to allow filtering on the station address.
This currently only works for data frames. A Fixme is in place for
managment frames.
Change-Id: I0a72a9a3e40cf8269856fbbcd97b270af422afa2
Reviewed-on: https://code.wireshark.org/review/10322
Reviewed-by: Jörg Mayer <[email protected]>
commit f0b4e8e
Author: Martin Kaiser <[email protected]>
Date: Sun Aug 30 20:31:35 2015 +0200
dlsw: don't THROW() an exception from a dissector
Change-Id: I897202e7fb2987f608ca4f98aa1a1dc4b7dbd995
Reviewed-on: https://code.wireshark.org/review/10320
Reviewed-by: Martin Kaiser <[email protected]>
commit 81c6ecd
Author: Martin Kaiser <[email protected]>
Date: Sun Aug 30 20:08:53 2015 +0200
dlsw: remove unnecessary if (tree) checks
don't create an expert info under if (tree)
Change-Id: I2c8f90483c434d708a97b621621ca123fc505edc
Reviewed-on: https://code.wireshark.org/review/10319
Reviewed-by: Martin Kaiser <[email protected]>
commit 78007fa
Author: Hadriel Kaplan <[email protected]>
Date: Sun Aug 30 10:16:16 2015 -0400
Add debug printing to tshark
Add g_warning functions for tshark debug printing, disabled by default.
Change-Id: If1720b790b75bd1228afa62efac49dc04bc8addb
Reviewed-on: https://code.wireshark.org/review/10314
Reviewed-by: Hadriel Kaplan <[email protected]>
commit 00087b4
Author: Pascal Quantin <[email protected]>
Date: Sat Aug 29 22:28:01 2015 +0200
Add Lua 5.2.3 built with MSVC2015
Change-Id: I9b173f5136f858e4f95fb5b0688ef02c08a8d9e4
Reviewed-on: https://code.wireshark.org/review/10313
Reviewed-by: Anders Broman <[email protected]>
commit 99e16ce
Author: Gerald Combs <[email protected]>
Date: Sun Aug 30 08:10:04 2015 -0700
[Automatic update for 2015-08-30]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I37400bf1fac15fcd5f2946913b96184b1828f091
Reviewed-on: https://code.wireshark.org/review/10317
Reviewed-by: Gerald Combs <[email protected]>
commit faaa6f2
Author: Pyeole <[email protected]>
Date: Sat Aug 29 15:36:41 2015 -0400
BGP: fixed incorrect NLRI decoding
Bug: 11308
Change-Id: I967b9596edad1e3656e139d0ca3a0e3c389d80ea
Reviewed-on: https://code.wireshark.org/review/10308
Reviewed-by: Alexis La Goutte <[email protected]>
commit e0a87d8
Author: Dario Lombardo <[email protected]>
Date: Thu Aug 27 18:01:27 2015 +0200
stanag4607: add check for wtap max size.
Bug: 11472
Change-Id: Ic269046e697ac5e65301caf4ea5586098d030458
Reviewed-on: https://code.wireshark.org/review/10279
Reviewed-by: Evan Huus <[email protected]>
Petri-Dish: Evan Huus <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Anders Broman <[email protected]>
commit 6c06578
Author: Pascal Quantin <[email protected]>
Date: Sat Aug 29 22:54:54 2015 +0200
CBOR: fix definition of cbor.type.tag64 field
Bug: 11486
Change-Id: I070c8c397a41c0c8231720c611938d7282c03d19
Reviewed-on: https://code.wireshark.org/review/10310
Petri-Dish: Pascal Quantin <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Pascal Quantin <[email protected]>
commit 7791c6f
Author: Hadriel Kaplan <[email protected]>
Date: Sat Aug 29 19:14:13 2015 -0400
pcapng: drop count is unknown for ISB without isb_if_drop option
Bug: 11489
Change-Id: I38bcc2570c2efc461e4eb0edbff8ac2a7371c725
Reviewed-on: https://code.wireshark.org/review/10311
Petri-Dish: Hadriel Kaplan <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Hadriel Kaplan <[email protected]>
commit 605f33c
Author: Hadriel Kaplan <[email protected]>
Date: Sat Aug 29 14:16:52 2015 -0400
pcapng: handle NRB with options
If a pcapng Name Resolution Block has options, they should not screw up the
pcapng reader and cause it to fail to read the file.
Bug: 11485
Change-Id: Ic27cba937b6d93a3d9ed92522ed6b39ae2daeb8f
Reviewed-on: https://code.wireshark.org/review/10307
Petri-Dish: Hadriel Kaplan <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Hadriel Kaplan <[email protected]>
commit eacaa1a
Author: Kevin Bracey <[email protected]>
Date: Wed Jul 22 15:36:07 2015 +0300
6LoWPAN: IPv6 Fragment Headers don't have a Length field
RFC 6282 specifies special handling of the "Length" field in compressed
IPv6 extension headers. However, the Fragment Header does not have a
Length field, so this special handling does not apply - the second octet
should be treated as opaque data, and the header length is always 8
octets.
Bug: 11368
Change-Id: I28fcd66d96f58a5959bb669caf4244afaca9e67e
Reviewed-on: https://code.wireshark.org/review/10231
Reviewed-by: Michael Mann <[email protected]>
Petri-Dish: Michael Mann <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Evan Huus <[email protected]>
commit 8ddd480
Author: Hadriel Kaplan <[email protected]>
Date: Sat Aug 29 10:30:15 2015 -0400
pcapng: do not byte-swap NRB IPv4 address
Per the spec, it's always encoded in network order (4 separate bytes), and
thus should not be swapped on read.
Bug: 11484
Change-Id: I6a650896b324f42bfd2e05759c84e87ace733372
Reviewed-on: https://code.wireshark.org/review/10304
Petri-Dish: Hadriel Kaplan <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Hadriel Kaplan <[email protected]>
commit 9158176
Author: Hadriel Kaplan <[email protected]>
Date: Sat Aug 29 10:00:02 2015 -0400
pcapng: make SPB cap_len the same as packet_len if IDB snaplen is 0
An IDB snaplen of 0 means no limit, so a Simple Packet Block's capture
length should be the same as its encoded packet length in such a case.
Bug: 11483
Change-Id: I8856d6c6a669a0048ea64b3adbd23c37a598431d
Reviewed-on: https://code.wireshark.org/review/10303
Petri-Dish: Hadriel Kaplan <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Hadriel Kaplan <[email protected]>
commit 0badc8c
Author: Jim Young <[email protected]>
Date: Fri Jul 10 01:50:19 2015 -0400
Insure Qt Capture preferences dialog displays default capture device (if any)
In CapturePreferencesFrame::updateWidgets() save and restore the default
capture device name because the first call (and only the first call) in
the loop with addItem() triggers on_defaultInterfaceComboBox_editTextChanged()
which unconditionally sets the default name as the first non-hidden device.
Bug: 10965
Change-Id: Ie93f84010a19e8144efa46ce889fb9064979e0e9
Reviewed-on: https://code.wireshark.org/review/9584
Reviewed-by: Gerald Combs <[email protected]>
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Hadriel Kaplan <[email protected]>
commit 51e77b6
Author: Alexis La Goutte <[email protected]>
Date: Fri Aug 28 15:53:42 2015 +0200
CBOR: fix no previous prototype for proto_reg*_cbor [-Wmissing-prototypes]
Change-Id: I20476046fc2338484ab85757cad7b19f4e41e4be
Reviewed-on: https://code.wireshark.org/review/10283
Petri-Dish: Alexis La Goutte <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Anders Broman <[email protected]>
commit 4ebf5b8
Author: Jeffrey Smith <[email protected]>
Date: Fri Aug 28 17:28:31 2015 -0500
bootp/dhcp: fix Alcatel suboption detection bug
Change-Id: I4a4222f3f30bf8e996770295756dd206b5ce101b
Reviewed-on: https://code.wireshark.org/review/10297
Reviewed-by: Anders Broman <[email protected]>
commit e80bd2e
Author: Stig Bjørlykke <[email protected]>
Date: Fri Aug 28 19:45:28 2015 +0200
Added Reload Lua plugins to the release notes.
Change-Id: I2ea50b331322e0bc66bf5f3b48d9c2e78bbdd1e5
Reviewed-on: https://code.wireshark.org/review/10285
Reviewed-by: Stig Bjørlykke <[email protected]>
commit e18e400
Author: Gerald Combs <[email protected]>
Date: Fri Aug 28 15:49:22 2015 -0700
Fix a GHashTable assertion in DecodeAsDialog.
Make sure we don't call g_hash_table_removed from g_hash_table_foreach,
which generates an assertion error.
Bug: 11426
Change-Id: I00283c97b0fc63551b901c0fd526b60c0fb80ace
Reviewed-on: https://code.wireshark.org/review/10296
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit 1663224
Author: Guy Harris <[email protected]>
Date: Fri Aug 28 16:31:33 2015 -0700
Block sizes are unsigned 32-bit quantities; don't stuff them into an int.
*Especially* don't stuff the amount of remaining data in a block into an
int that will then be passed to file_skip() as an amount to skip ahead,
as a Really Large Value will turn into a negative value and produce
various forms of bizarre and tricky-to-debug behavior.
Change-Id: I4d0a6b36fe50df84925690ad688a3ab0433ceb17
Reviewed-on: https://code.wireshark.org/review/10299
Reviewed-by: Guy Harris <[email protected]>
commit 15c9923
Author: Stig Bjørlykke <[email protected]>
Date: Fri Aug 28 23:30:30 2015 +0200
Qt: Fix use-after-free pattern
Change-Id: I7f6d9316234c1ccfec1ec5b5c3675b3237f22eda
Reviewed-on: https://code.wireshark.org/review/10294
Petri-Dish: Stig Bjørlykke <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit 579365e
Author: Gerald Combs <[email protected]>
Date: Fri Aug 28 14:03:34 2015 -0700
Disable most of the main window while we're tapping.
Our event loop is nested when we read packets. Disable the main window's
central widget while we're retapping packets in order to minimize the
chance of ending up in an unexpected state while analyzing packets.
Note that we will probably want to disable more of the main window and
do so in other parts of the code.
Change-Id: I68a00fe43d2ac9e7c0749751abd1c10c47155b3b
Reviewed-on: https://code.wireshark.org/review/10293
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit 4d71ae7
Author: Guy Harris <[email protected]>
Date: Fri Aug 28 15:54:53 2015 -0700
Have separate variables for read and write errors.
That way, when we check for read errors, we don't run the risk of
thinking we have a read error after we get a write error.
Change-Id: Idb79822d30989b2529433878798c577a76eacca7
Reviewed-on: https://code.wireshark.org/review/10295
Reviewed-by: Guy Harris <[email protected]>
commit aa100e0
Author: Gerald Combs <[email protected]>
Date: Fri Aug 28 12:57:57 2015 -0700
Don't show a progress frame if our file was closed.
Change-Id: Ie363f6764f4e8b2b5c476b85f7ddb0233a127f6e
Reviewed-on: https://code.wireshark.org/review/10290
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit c1c6132
Author: Gerald Combs <[email protected]>
Date: Fri Aug 28 12:28:24 2015 -0700
Don't dissect twice from TapParameterDialog.
When the user applies a display filter in TapParameterDialog we're about
to start tapping. We need to set the display filter in the main window
but we shouldn't apply it.
Change-Id: I08bed5c7f470f1dbf32817a7d999f09d2c52f168
Reviewed-on: https://code.wireshark.org/review/10287
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit d767186
Author: Guy Harris <[email protected]>
Date: Fri Aug 28 12:49:18 2015 -0700
Get rid of trailing blanks.
Change-Id: I0b705c924464dcc4987ed0e7c67b106b2b648dce
Reviewed-on: https://code.wireshark.org/review/10289
Reviewed-by: Guy Harris <[email protected]>
commit da266af
Author: Guy Harris <[email protected]>
Date: Fri Aug 28 12:46:11 2015 -0700
Don't check the radio information when testing for an HT Control header.
I now read 8.2.4.1.10 "Order field" in 802.11-2012 as saying that, in
management and QoS data frames, the Order bit shouldn't be set for
non-HT, non-VHT frames, so we can just test it for those frame types
without bothering to check the radio metadata to see if the frame is an
HT or VHT frame.
This handles cases where the radio metadata isn't complete, e.g. an HT
frame with a radiotap header but no MCS field.
Handle this for *all* QoS data frames when capturing.
Get rid of the "fixed-length link-layer header" stuff; it's not being
used.
Fix a case where we're appending text to a tree item without a space
separating it from the previous text.
Bug: 11351
Change-Id: I980f5b7509603b0c22c297fddc19434c08817913
Reviewed-on: https://code.wireshark.org/review/10288
Reviewed-by: Guy Harris <[email protected]>
commit 42570f9
Author: Guy Harris <[email protected]>
Date: Fri Aug 28 12:05:20 2015 -0700
Clean up scanning to guess the bitrate of an MPEG-2 Transport Stream file.
Don't treat an EOF at the beginning of a frame as an error.
Treat I/O errors as hard errors; treat short reads as an indication that
the file isn't an MPEG-2 Transport Stream file.
Treat the PCR for a given PID not going forward as an indication that
the file isn't an MPEG-2 Transport Stream file.
Bug: 11471
Change-Id: I42b5887049423f8265db9d121d7b5bd388e5b244
Reviewed-on: https://code.wireshark.org/review/10286
Reviewed-by: Guy Harris <[email protected]>
commit c04d54f
Author: Pascal Quantin <[email protected]>
Date: Thu Aug 27 23:35:58 2015 +0200
Preparation Host Flows: make ICMP(v6) code and type retrieval more robust
Do not retrieve type and code base on the info column content.
Instead store type and code in pinfo structure and retrieve them in sequence analysis tap.
Change-Id: I71cd505d7faf713c2372731495d47b45928a41f8
Reviewed-on: https://code.wireshark.org/review/10280
Petri-Dish: Pascal Quantin <[email protected]>
Reviewed-by: Pascal Artho <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Pascal Quantin <[email protected]>
commit 5179406
Author: Gerald Combs <[email protected]>
Date: Fri Aug 28 09:50:26 2015 -0700
Update the release notes.
Change-Id: I7fb0d307355320a77f011b59c71d1d54066b7d08
Reviewed-on: https://code.wireshark.org/review/10284
Reviewed-by: Gerald Combs <[email protected]>
commit a7f22aa
Author: Alexis La Goutte <[email protected]>
Date: Mon Jul 27 17:00:18 2015 +0200
ISAKMP: Add new CHACHA20/POLY1305 Transform Types Values (RFC7634)
From IANA ikev2-parameters (2015-08-24)
Change-Id: I02bfd9a0ffc9f863f4d266fcc56cd707c3e71725
Reviewed-on: https://code.wireshark.org/review/10282
Reviewed-by: Anders Broman <[email protected]>
commit f19a173
Author: Gerald Combs <[email protected]>
Date: Wed Aug 26 17:14:39 2015 -0700
Speed up column sorting.
The GTK+ UI sequentially dissects and caches column strings for all rows
before sorting a column. Do the same in the Qt UI, which can improve
performance considerably.
Don't colorize packets when sorting in the Qt UI unless it's necessary.
When sorting in the Qt UI, let the user cancel the initial packet
dissection. Note that we'll need to replace std::sort in order to
cancel out of sorting.
Use a pre-allocated and pre-compiled GRexex when we prime columns. Note
that we probably shouldn't parse a regular expression there.
Cache the last result of proto_registrar_get_byname.
Note performance hot spots elsewhere in the code.
To do:
GeoIP in packet-ip.c is pretty slow.
Bug: 11467
Change-Id: Ib34038fee08ef0319261faeffc4eca01e52f4bd3
Reviewed-on: https://code.wireshark.org/review/10275
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit 01fb470
Author: Gerald Combs <[email protected]>
Date: Wed Aug 26 12:48:56 2015 -0700
More retapping fixups.
Disable the main file close and reload actions while we're retapping,
otherwise many of our dialogs will crash.
Disable the TapParameterDialog filter entry while we're retapping. This
keeps us from enabling the "Apply" button when we shouldn't.
Don't prematurely disconnect our signals in WiresharkDialog.
Change-Id: Iaf507eb4503b9c296766f109f2b8c71343263982
Reviewed-on: https://code.wireshark.org/review/10274
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
commit 30c2f23
Author: Michael Mann <[email protected]>
Date: Tue Aug 25 20:58:09 2015 -0400
Eliminate proto_tree_add_text from some dissectors.
Change-Id: I066b70cfd58f5fb3ffbcb2e238416747d9e7dd57
Reviewed-on: https://code.wireshark.org/review/10269
Reviewed-by: Michael Mann <[email protected]>
Petri-Dish: Michael Mann <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Anders Broman <[email protected]>
commit 2ed634d
Author: Stig Bjørlykke <[email protected]>
Date: Mon Aug 24 15:00:39 2015 +0200
Support BER files bigger than 256kB
Also support APPLICATION as starting tag.
Change-Id: Id85b08e2594969c98c530532a32268b01d50965e
Reviewed-on: https://code.wireshark.org/review/10233
Petri-Dish: Stig Bjørlykke <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Stig Bjørlykke <[email protected]>
commit e3a4188
Author: Didier Arenzana <[email protected]>
Date: Sun Aug 23 20:54:38 2015 +0200
RADIUS: Validation of response authenticators
This patch enables validation of response authenticator messages when
the shared secret is known.
The validation can be activated in the preferences.
It implements the validation protocol described in RFC 2865 page 16: Response Authenticator.
When an authenticator is invalid, the information is added in the header information.
It adds two flags for the display filter : radius.authenticator.valid and
radius.authenticator.invalid: since verification is not always possible we use
two flags to determine if the verification has been made or not, in the same way as
udp and tcp checksum validation is implemented.
The Authenticator field becomes a tree, and the value of the flags are visible in
this tree.
Change-Id: I33a664f2265c6248e106cee7904c754089d50445
Reviewed-on: https://code.wireshark.org/review/10216
Petri-Dish: Alexis La Goutte <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Alexis La Goutte <[email protected]>
commit 6151946
Author: Stig Bjørlykke <[email protected]>
Date: Tue Aug 25 14:51:50 2015 +0200
Qt: Fixed some memory leakages
Change-Id: I5bccf706001f9ff41197ed13b1be5a7404ca594f
Reviewed-on: https://code.wireshark.org/review/10251
Petri-Dish: Stig Bjørlykke <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Stig Bjørlykke <[email protected]>
commit efba977
Author: Stig Bjørlykke <[email protected]>
Date: Tue Aug 25 15:18:51 2015 +0200
Qt: Fixed some memory leakages
Change-Id: Ie8c9b7f8c9203acb5aec00d5553b911e0299f53c
Reviewed-on: https://code.wireshark.org/review/10253
Petri-Dish: Stig Bjørlykke <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Stig Bjørlykke <[email protected]>
commit 8384a5b
Author: Stig Bjørlykke <[email protected]>
Date: Tue Aug 25 20:18:46 2015 +0200
Qt: Fixed some memory leakages
And changed strdup -> g_strdup
Change-Id: I62de106462259194738d633f16297eb1210f8ccf
Reviewed-on: https://code.wireshark.org/review/10259
Reviewed-by: Stig Bjørlykke <[email protected]>
commit 2e1fa63
Author: Alexis La Goutte <[email protected]>
Date: Wed Aug 26 10:32:52 2015 +0200
Lemon grammar: fix indent (use tabs)
Change-Id: I6fa38d5d85b25ac6c55fcfa67d6c8dba8482cc8c
Reviewed-on: https://code.wireshark.org/review/10266
Petri-Dish: Alexis La Goutte <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Anders Broman <[email protected]>
commit 0af048b
Author: Michael Mann <[email protected]>
Date: Tue Aug 25 19:14:59 2015 -0400
Remove calls of tvb_ensure_length_remaining.
The remaining calls seem to fall into 3 categories:
1. passing it to tvb_find_line_end when -1 (for length) will do.
2. duplicating the checking of tvb_reported_length_remaining, which is already in use near the tvb_ensure_length_remaining call.
3. Those that (probably) need tvb_ensure_capture_length_remaining
Change-Id: I1e77695251e055644bcbbb89f3c181c65d1671ca
Reviewed-on: https://code.wireshark.org/review/10268