Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is failing due to dependency conflict on click (kytos in develop mode) #61

Open
italovalcy opened this issue Dec 23, 2021 · 1 comment

Comments

@italovalcy
Copy link

italovalcy commented Dec 23, 2021

The docker build for amlight/kytos:latest (https://github.com/amlight/kytos-docker/blob/master/Dockerfile) is failing due to a dependency conflict on click.

It looks like since commit f19131a flow_manager's updated its dependency on click to click>=7.1.2 and then on commit 399c50a it was updated to click==8.0.3 (both sees to be related to black: requirements/dev.in:black>=21.10b0 # 21.x requires click>=7.1.2). However, most of the other napps depends on click==7.1.1:

root@fcfdcf68586e:/src# grep "^click" . -R
./python-openflow/requirements/dev.txt:click==7.1.1              # via pip-tools
./kytos-flow-manager/requirements/dev.txt:click==8.0.3
./kytos-pathfinder/requirements/dev.txt:click==7.1.1 # via pip-tools
./kytos-of-lldp/requirements/dev.txt:click==7.1.1              # via flask, pip-tools
./kytos-topology/requirements/dev.txt:click==7.1.1              # via pip-tools
./kytos-of-core/requirements/dev.txt:click==7.1.1              # via flask, kytos, pip-tools
./kytos-storehouse/requirements/dev.txt:click==7.1.1              # via pip-tools
./kytos/kytos.egg-info/requires.txt:click>=7.1.1
./kytos/requirements/dev.txt:click==7.1.1              # via -r requirements/run.txt, flask, pip-tools
./kytos/requirements/run.txt:click>=7.1.1              # via flask
./kytos-utils/requirements/dev.txt:click==7.1.1
@italovalcy italovalcy changed the title Build is failing due to dependency conflict on click Build is failing due to dependency conflict on click (kytos in develop mode) Dec 23, 2021
@italovalcy
Copy link
Author

I forgot to mention that this only happens if I use Kytos, Kytos-utils and python-openflow in develop mode during build (python3 -m pip install -e ...: project in editable mode (i.e. setuptools "develop mode")):

diff --git a/Dockerfile b/Dockerfile
index 8e1ee26..2fb4999 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -13,9 +13,9 @@ RUN sed -i '/imklog/ s/^/#/' /etc/rsyslog.conf
 RUN git config --global url."https://github.com".insteadOf git://github.com

 RUN python3 -m pip install --upgrade pip setuptools wheel
-RUN python3 -m pip install https://github.com/kytos-ng/python-openflow/archive/master.zip
-RUN python3 -m pip install https://github.com/kytos-ng/kytos-utils/archive/master.zip
-RUN python3 -m pip install https://github.com/kytos-ng/kytos/archive/master.zip
+RUN python3 -m pip install -e git+https://github.com/kytos-ng/python-openflow#egg=python-openflow
+RUN python3 -m pip install -e git+https://github.com/kytos-ng/kytos-utils#egg=kytos-utils
+RUN python3 -m pip install -e git+https://github.com/kytos-ng/kytos#egg=kytos

 RUN python3 -m pip install -e git+https://github.com/kytos-ng/storehouse#egg=kytos-storehouse
 RUN python3 -m pip install -e git+https://github.com/kytos-ng/of_core#egg=kytos-of_core

Full output generated: https://gist.github.com/italovalcy/dc7d9cdcb2678f6e896741c6373b0f5e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant