Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing python3 setup.py develop with pip install -e . #28

Open
viniarck opened this issue Jun 28, 2022 · 0 comments
Open

Consider replacing python3 setup.py develop with pip install -e . #28

viniarck opened this issue Jun 28, 2022 · 0 comments
Labels
enhancement New feature or request epic_documentation Documentation improvements

Comments

@viniarck
Copy link
Member

When executing python3 setup.py develop although the dependencies are frozen, looks like there's margin for some libs to have issues with eggs or wheels like it was shown on PR #27.

❯ kytos napps list
Traceback (most recent call last):
  File "/tmp/kytos-utils-2/.direnv/python-3.9.12/bin/kytos", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/tmp/kytos-utils-2/bin/kytos", line 48, in <module>
    from kytos.cli.commands.napps.parser import parse
  File "/tmp/kytos-utils-2/kytos/cli/commands/napps/parser.py", line 43, in <module>
    from kytos.cli.commands.napps.api import NAppsAPI
  File "/tmp/kytos-utils-2/kytos/cli/commands/napps/api.py", line 11, in <module>
    from kytos.utils.napps import NAppsManager
  File "/tmp/kytos-utils-2/kytos/utils/napps.py", line 16, in <module>
    from ruamel.yaml import YAML
ImportError: cannot import name 'YAML' from 'ruamel.yaml' (/tmp/kytos-utils-2/.direnv/python-3.9.12/lib/python3.9/site-packages/ruamel.yaml.clib-0.2.6-py3.9-linux-x86_64.egg/ruamel/yaml/
__init__.py)

If you install it with pip install -e . it also executes the develop mode and the same issue doesn't happen. We should consider replacing the python3 setup.py develop setup instructions in the future to avoid this type of surprise.

@viniarck viniarck added the enhancement New feature or request label Jun 28, 2022
@viniarck viniarck changed the title Consider replacing python3 setup.py develop with pip install install -e . Consider replacing python3 setup.py develop with pip install -e . Jun 28, 2022
@viniarck viniarck added the 2022.3 Kytos-ng 2022.3 label Jul 7, 2022
@viniarck viniarck added 2023.1 Kytos-ng 2023.1 and removed 2022.3 Kytos-ng 2022.3 labels Nov 16, 2022
@viniarck viniarck added 2023.2 Kytos-ng 2023.2 and removed 2023.1 Kytos-ng 2023.1 labels May 15, 2023
@viniarck viniarck added future_release Planned for the next release and removed 2023.2 Kytos-ng 2023.2 labels Nov 28, 2023
@viniarck viniarck added epic_documentation Documentation improvements and removed future_release Planned for the next release labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic_documentation Documentation improvements
Projects
None yet
Development

No branches or pull requests

1 participant