Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: let db_conn_or_core_shutdown and init_apm_or_core_shutdown reraise their exceptions #415

Closed
viniarck opened this issue Sep 26, 2023 · 0 comments · Fixed by #419
Closed
Assignees
Labels
2023.2 Kytos-ng 2023.2 tech_debt Tech debt

Comments

@viniarck
Copy link
Member

Once PR #414 lands, there's room to simplify both db_conn_or_core_shutdown and init_apm_or_core_shutdown and allow their exceptions to be caught as a broad one, during controller.start, since we're already dealing with a broad exc for this case anyway to catch any sort of error, so it should be ok without compromising redability, this is just a chore, functionality wise it'll behave the same:

https://github.com/kytos-ng/kytos/blob/master/kytos/core/controller.py#L254-L258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.2 Kytos-ng 2023.2 tech_debt Tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant