Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor log.info "Limited reached" as "Limit reached" #498

Closed
viniarck opened this issue Sep 5, 2024 · 1 comment · Fixed by #499
Closed

chore: refactor log.info "Limited reached" as "Limit reached" #498

viniarck opened this issue Sep 5, 2024 · 1 comment · Fixed by #499
Assignees
Labels
2024.1 Kytos-ng 2024.1

Comments

@viniarck
Copy link
Member

viniarck commented Sep 5, 2024

I just realized that one "Limited reached" log entry remained:

https://github.com/kytos-ng/kytos/blob/master/kytos/core/pacing.py#L170

On PR #497 this log entry was supposed to be refactored, but this has been left behind unexpectedly. This is a very cosmetic/trivial thing, but since this log message is so helpful for grepping in the logs it's great to have it fixed too and normalized. @Ktmi can you send a quick PR? It's up to you if you wish to send a new patch or just a new PR without bumping the version and then you retag/re-release 2024.1.1 again, since this is pretty recent it's ok to do it.

@viniarck viniarck added the 2024.1 Kytos-ng 2024.1 label Sep 5, 2024
@Ktmi
Copy link

Ktmi commented Sep 5, 2024

@viniarck Oh, I refactored that already in the previous PR.

Edit: NVM I only did the one :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024.1 Kytos-ng 2024.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants