Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchTCPSrc and MatchTCPDst should be named tcp_src/tcp_dst instead of tp_src/tp_dst #6

Open
ajoaoff opened this issue Jun 7, 2021 · 0 comments

Comments

@ajoaoff
Copy link

ajoaoff commented Jun 7, 2021

Original issue opened by @italovalcy at kytos#98.

Hi team,

I saw that you are using the name 'tp_src' and tp_dst for the MatchTCPSrc and MatchTCPDst, respectively, in v0x04/match_fields.py. I suggest you guys rename it to tcp_src and tcp_dst, which is more complaint with the naming schema of OF1.2+. The names tp_src/tp_dst were used on OF1.0, where they referred generically to the transport (tp) port.

We need to be careful when renaming this to avoid the tests and other napps break (even though I think there is no other napp using it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant