-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a way to handle 4096/4096
and 0
#98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A conditional introduced doesn't look right to me, if you could double check. I left more information in the comment. Thanks.
vlanId
as str4096/4096
and 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alopalao this is getting close to land, could you also update the changelog and also add explain which local tests you've run to confirm this? Let's also add e2e tests to cover these cases before merging this, specially since it's protocol dependent, so the earlier we have this cov on OvS with e2e tests the better. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alopalao I'll leave this PR pre-approved.
When kytos-ng/kytos-end-to-end-tests#210, feel free to merge it as well. In this PR here, the only small remaining changes are a suggestion in the changelog, and maybe the extra unit test, but since you're unit test is already covering maybe we don't need that either, I'll leave it up to you.
Co-authored-by: Vinicius Arcanjo <[email protected]>
Related to mef_eline PR #258
Summary
From
MatchDLVLAN.as_of_tlv()
,self.value
now can be non-existentVlanId.OFPVID_NONE
From
MatchDLVLAN.from_of_tlv()
,tlv.oxm_value
now can handle theany
case withoxm_value = '4096/4096'
Local Tests
Installing this EVC through
mef_eline
api:Does not trigger consistency check loop (alien, delete, missing, install) with different values for the UNI tags. Confirming that the de-serialization is working as desired.