Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted to exception for vlan usage #99

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Adapted to exception for vlan usage #99

merged 3 commits into from
Nov 22, 2023

Conversation

Alopalao
Copy link

@Alopalao Alopalao commented Oct 30, 2023

Closes #98

Summary

Adapted main methods that are Interfaces related to capture KytosTagsAreNotAvailable and KytosTagsNotInTagRanges

Local Tests

Updated unit tests
Raised exceptions manually

End-To-End Tests

============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.3.0
rootdir: /tests
plugins: timeout-2.1.0, rerunfailures-10.2, anyio-3.6.2
collected 244 items

tests/test_e2e_01_kytos_startup.py ..                                    [  0%]
tests/test_e2e_05_topology.py ..................                         [  8%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x................  [ 24%]
tests/test_e2e_11_mef_eline.py ......                                    [ 27%]
tests/test_e2e_12_mef_eline.py .....Xx.                                  [ 30%]
tests/test_e2e_13_mef_eline.py ....Xs.s.....Xs.s.XXxX.xxxx..X........... [ 47%]
.                                                                        [ 47%]
tests/test_e2e_14_mef_eline.py x                                         [ 47%]
tests/test_e2e_15_mef_eline.py ....                                      [ 49%]
tests/test_e2e_20_flow_manager.py .....................                  [ 58%]
tests/test_e2e_21_flow_manager.py ...                                    [ 59%]
tests/test_e2e_22_flow_manager.py ...............                        [ 65%]
tests/test_e2e_23_flow_manager.py ..............                         [ 71%]
tests/test_e2e_30_of_lldp.py ....                                        [ 72%]
tests/test_e2e_31_of_lldp.py ...                                         [ 74%]
tests/test_e2e_32_of_lldp.py ...                                         [ 75%]
tests/test_e2e_40_sdntrace.py .............                              [ 80%]
tests/test_e2e_41_kytos_auth.py ........                                 [ 84%]
tests/test_e2e_42_sdntrace.py ..                                         [ 84%]
tests/test_e2e_50_maintenance.py ........................                [ 94%]
tests/test_e2e_60_of_multi_table.py .....                                [ 96%]
tests/test_e2e_70_kytos_stats.py ........                                [100%]

Note:
This PR relies on kytos PR.

@Alopalao Alopalao requested a review from a team as a code owner October 30, 2023 22:53
requirements/dev.in Outdated Show resolved Hide resolved
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's great to have the new exceptions, and also still have the conflict data when it ever happens. I'll approve this PR once the PR it depends on is ready to land. No need to update the changelog in this case since it's mostly refactoring.

Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really nice how KytosTagError and overall exceptions have been structured. I'll approve this PR once the kytos PR it depends on is also approved.

Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this pre-approved, let's revert #99 (comment) as Aldo mentioned when the PR this PR depends on kytos-ng/kytos#428. Once Kytos PR 428 is merged, let's merge this one right after.

@viniarck viniarck merged commit 0d5fad9 into master Nov 22, 2023
1 check passed
@viniarck viniarck deleted the epic/vlan_range branch November 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adpat vlan usage to exception raising from Interface
2 participants