Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adapt code to support dl_vlan when it has a mask #78

Closed
viniarck opened this issue Mar 2, 2023 · 4 comments
Closed

feat: adapt code to support dl_vlan when it has a mask #78

viniarck opened this issue Mar 2, 2023 · 4 comments
Assignees
@gretelliz
Labels
2023.1 Kytos-ng 2023.1 epic_mef_eline_vlan_range mef_eline VLAN range priority_major Major priority

Comments

@viniarck
Copy link
Member

viniarck commented Mar 2, 2023 •
edited
Loading

flow_manager is being updated to support dl_vlan value/mask on this issue kytos-ng/flow_manager#132

Related PR on flow_manager has just landed
@viniarck viniarck added priority_major Major priority 2023.1 Kytos-ng 2023.1 epic_mef_eline_vlan_range mef_eline VLAN range labels Mar 2, 2023
@viniarck
Copy link
Member Author

viniarck commented Mar 2, 2023

Issue discussion regarding mask and payload is going on here for the record

@viniarck viniarck mentioned this issue Mar 6, 2023
Merged
@gretelliz gretelliz self-assigned this Mar 7, 2023
@viniarck viniarck changed the title chore: adapt code to support dl_vlan as str with and without a mask chore: adapt code to support dl_vlan when it has a mask Mar 8, 2023
@viniarck viniarck changed the title chore: adapt code to support dl_vlan when it has a mask feat: adapt code to support dl_vlan when it has a mask Mar 8, 2023
@gretelliz
Copy link
Contributor

@viniarck, Currently dl_vlan in flows supports mask, while dl_vlan in packet args is an integer into [1, 4095]. We shouldn't support a mask in the payload input, so this issue can be closed, right?

@viniarck
Copy link
Member Author

@viniarck, Currently dl_vlan in flows supports mask, while dl_vlan in packet args is an integer into [1, 4095]. We shouldn't support a mask in the payload input, so this issue can be closed, right?

That's correct @gretelliz, yes no mask in the input. Also, looking into unit test test_match_field_dl_vlan, it's also covering there, so the way it's converting and how the value is being passed looks good to me, feel free to close it.

@gretelliz
Copy link
Contributor

Thank you!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gretelliz gretelliz

Labels
2023.1 Kytos-ng 2023.1 epic_mef_eline_vlan_range mef_eline VLAN range priority_major Major priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viniarck @gretelliz