Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt to support untagged and any on EVCs from mef_eline #79

Closed
Alopalao opened this issue Mar 6, 2023 · 2 comments · Fixed by #82
Closed

chore: adapt to support untagged and any on EVCs from mef_eline #79

Alopalao opened this issue Mar 6, 2023 · 2 comments · Fixed by #82
Labels
2023.1 Kytos-ng 2023.1 epic_general Generic enhancement and/or fixes epic_sdntrace_cp sdntrace_cp

Comments

@Alopalao
Copy link
Contributor

Alopalao commented Mar 6, 2023

sdn_trace is being updated (on this issue) to support Tag.value as str (untagged and any)

  • openapi.yml need to be adapted now that Tag is not required and its value can take a string.
  • New possibles strings for EVCs uni.user_tag.value are "any" and "untagged" which are going to send flows with changed values "4096/4096" and 0 respectively. This data can be seen better in this google sheet

Edited: as discussion progresses

@viniarck viniarck added 2023.1 Kytos-ng 2023.1 epic_sdntrace_cp sdntrace_cp labels Mar 7, 2023
@viniarck
Copy link
Member

viniarck commented Mar 7, 2023

As @Alopalao initially highlighted will likely maintain dl_vlan: 0, initially I pointed out as a str, but as the discussion/review is unfolding here kytos-ng/flow_manager#135 we'll likely stick with str only for masks.

@viniarck viniarck added the epic_general Generic enhancement and/or fixes label Mar 13, 2023
@Alopalao
Copy link
Contributor Author

Alopalao commented Mar 14, 2023

After last update, consistency check is working fine for these changes just a little note.
Something unexpected is happening with untagged and any. For this EVC, for example:

    {"name": "my evc1",
    "dynamic_backup_path": true,
    "enabled": true,
    "uni_a": {"tag": {"tag_type": 1, "value": "any"},
                  "interface_id": "00:00:00:00:00:00:00:01:1"},
    "uni_z": {"tag": {"tag_type": 1, "value": "untagged"},
                  "interface_id": "00:00:00:00:00:00:00:02:1"}}

After deleting every flow and restarting the console, all the flows are installed correctly. Immediately after it, this event happens 6 times:

2023-03-14 15:43:52,074 - WARNING [kytos.napps.kytos/mef_eline] (mef_eline) Invalid trace from uni_a: [{'dpid': '00:00:00:00:00:00:00:01', 'out': None, 'port': 1, 'time': '2023-03-14 15:43:52.071198', 'type': 'incomplete', 'vlan': 'any'}]

After ~6 minutes, the messages stop, the EVC is deployed and flows are installed again (duration is reset). Switch 3 ends up having 2 extra flows.

 cookie=0xaa1ecdcf00a7084f, duration=432.306s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=20000,in_port="s3-eth3",dl_vlan=2 actions=set_field:4098->vlan_vid,output:"s3-eth2"
 cookie=0xaa1ecdcf00a7084f, duration=432.304s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=20000,in_port="s3-eth2",dl_vlan=2 actions=set_field:4098->vlan_vid,output:"s3-eth3"
 cookie=0xaa1ecdcf00a7084f, duration=427.220s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=20000,in_port="s3-eth3",dl_vlan=1 actions=set_field:4097->vlan_vid,output:"s3-eth2"
 cookie=0xaa1ecdcf00a7084f, duration=427.219s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=20000,in_port="s3-eth2",dl_vlan=1 actions=set_field:4097->vlan_vid,output:"s3-eth3"

Note: I am using the topology from e2e test helper RingTopo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.1 Kytos-ng 2023.1 epic_general Generic enhancement and/or fixes epic_sdntrace_cp sdntrace_cp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants