Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage last_status metadata to notify only once #103

Closed
viniarck opened this issue Jul 20, 2022 · 0 comments · Fixed by #114
Closed

Leverage last_status metadata to notify only once #103

viniarck opened this issue Jul 20, 2022 · 0 comments · Fixed by #114
Assignees
Labels
2022.3 Kytos-ng 2022.3 enhancement New feature or request

Comments

@viniarck
Copy link
Member

Currently, certain notify_link_status_change calls are being refactored to always check the for the status property to make sure there aren't other protocol related features that might be resulting in protocol down. However, currently, there can be more than one notification, for instance:

If a link goes up, and then liveness goes up after that it could send a kytos/topology.link_up notification twice, so to solve this in a agnostic way without extra conditionals on multiple places we could leverage the last_status that will be delivered on issue #99, and then whenever a handler needs to send a notification it can check if the last_status for an entity is the same or not, in addition to checking the current status, so if the last_status is the same then no new notifications are needed.

@viniarck viniarck added enhancement New feature or request 2022.3 Kytos-ng 2022.3 labels Jul 20, 2022
@viniarck viniarck added 2023.1 Kytos-ng 2023.1 and removed 2022.3 Kytos-ng 2022.3 labels Nov 16, 2022
@viniarck viniarck self-assigned this Nov 18, 2022
@viniarck viniarck added 2022.3 Kytos-ng 2022.3 and removed 2023.1 Kytos-ng 2023.1 labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2022.3 Kytos-ng 2022.3 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant