Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PortMod should be sent when an interface is disabled or enabled #72

Open
viniarck opened this issue Mar 1, 2022 · 0 comments
Open

PortMod should be sent when an interface is disabled or enabled #72

viniarck opened this issue Mar 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@viniarck
Copy link
Member

viniarck commented Mar 1, 2022

Currently, when an interface is disabled even tough the enabled state will be set as false, a PortMod OpenFlow message isn't being sent, as a result it's possible to have an interface enabled: False, and active: True, since it won't actually administratively disable the interface on the switch.

When implementing this feature, the PortConfig config should correctly use the OFPPC_PORT_DOWN flag, and the advertise capability shouldn't be impacted. This also should be tested with NoviFlow switches to make sure it'll work as intended and no side effect is observed, simulating a disable/enable should bring up a link correctly. Also, an end-to-end test should be added to make sure we have it covered for OvS OF 1.3.

An existing workaround, even though it won't send the actual PortMod message, but if an operator were also to shut down via another management plane that would have an equivalent effect, but it's not that practical to keep doing this.

@viniarck viniarck added enhancement New feature or request priority_major Major priority 2022.3 Kytos-ng 2022.3 labels Mar 1, 2022
@viniarck viniarck added 2023.1 Kytos-ng 2023.1 and removed 2022.3 Kytos-ng 2022.3 labels Nov 16, 2022
@viniarck viniarck added future_release Planned for the next release and removed 2023.1 Kytos-ng 2023.1 labels Dec 16, 2022
@viniarck viniarck removed the priority_major Major priority label Jul 7, 2023
@viniarck viniarck removed the future_release Planned for the next release label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant