Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notification methods #115

Merged
merged 6 commits into from
Dec 1, 2022
Merged

Conversation

Alopalao
Copy link

@Alopalao Alopalao commented Nov 29, 2022

Closes #71

  • Added switch links enable/disable notifications
  • Added interface links enable/disable notifications

- Added switch links enable/disable notifications
- Added interface links enable/disable notifications
-Fixed lint
@Alopalao Alopalao marked this pull request as ready for review November 29, 2022 18:47
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alopalao good job how you've introduced the methods, they have very well defined responsibilities and easy to test. Overall looks good, but we'll need also to cover some points that I mentioned, thanks.

main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
@viniarck
Copy link
Member

Aldo, when you have a chance, please update the changelog summarizing the notification changes you're introducing. Let me know if you've also explored it locally, looks like it's almost ready to land. Thanks.

@Alopalao
Copy link
Author

Yeah, here are the logs. I changed the log from mef_eline/handle_link_up to log.info:

kytos $> 2022-11-30 14:03:41,707 - INFO [kytos.napps.kytos/mef_eline] (thread_pool_app_1) Event handle_link_up kytos/topology.link_up
kytos $> 2022-11-30 14:03:55,061 - INFO [kytos.napps.kytos/mef_eline] (thread_pool_app_0) Event handle_link_down Link(Interface('s2-eth3', 3, Switch('00:00:00:00:00:00:00:02')), Interface('s3-eth2', 2, Switch('00:00:00:00:00:00:00:03')))

@viniarck viniarck self-requested a review November 30, 2022 20:49
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
- Updated readme.rst
@viniarck viniarck deleted the branch kytos-ng:master December 1, 2022 13:42
@viniarck viniarck closed this Dec 1, 2022
@viniarck viniarck reopened this Dec 1, 2022
@viniarck viniarck changed the base branch from fix/link_up_notify to master December 1, 2022 13:47
@viniarck
Copy link
Member

viniarck commented Dec 1, 2022

When I merged #114, it auto deleted the branch that this PR depends on, I just restored it, and updated this PR to use master as base. I'll review this PR shortly.

@viniarck viniarck self-requested a review December 1, 2022 14:45
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic contribution, @Alopalao

img

@viniarck viniarck merged commit 4b578f6 into kytos-ng:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling an interface or a switch isn't publishing kytos/topology.link_down for existing links
2 participants