From d7fa99cbce497b4bb18d9c96778706c669526a91 Mon Sep 17 00:00:00 2001
From: Sanskarzz <sanskar.gur@gmail.com>
Date: Mon, 1 Apr 2024 20:48:01 +0530
Subject: [PATCH] Added negetive cases

Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
---
 pkg/functions/functions_test.go | 55 +++++++++++++++++----------------
 pkg/scratch/scratch_test.go     | 18 +++++++++++
 2 files changed, 47 insertions(+), 26 deletions(-)

diff --git a/pkg/functions/functions_test.go b/pkg/functions/functions_test.go
index ab22dee..29dc99e 100644
--- a/pkg/functions/functions_test.go
+++ b/pkg/functions/functions_test.go
@@ -3,7 +3,7 @@ package functions
 import (
 	"fmt"
 	"reflect"
-	"sort"
+
 	"testing"
 )
 
@@ -21,6 +21,7 @@ func Test_jwt_decode(t *testing.T) {
 		wantErr bool
 	}{
 		{
+			name: "Positive case , function returns what we expected",
 			args: args{[]any{token, secret}},
 			want: map[string]interface{}{
 				"header": map[string]interface{}{
@@ -37,6 +38,28 @@ func Test_jwt_decode(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		// Negative test case: passing incorrect arguments (invalid token)
+		{
+			name: "negative case - invalid token",
+			args: args{[]any{"invalid_jwt_token", secret}},
+			want: map[string]interface{}{
+				"header":  nil,
+				"payload": nil,
+				"sig":     nil,
+			},
+			wantErr: true,
+		},
+		// Negative test case: passing incorrect arguments (invalid secret)
+		{
+			name: "negative case - invalid secret",
+			args: args{[]any{token, "invalid_secret"}},
+			want: map[string]interface{}{
+				"header":  nil,
+				"payload": nil,
+				"sig":     nil,
+			},
+			wantErr: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -45,35 +68,15 @@ func Test_jwt_decode(t *testing.T) {
 				t.Errorf("jwt_decode() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			}
-			gotMap := got.(map[string]any)
-			wantSorted := sortMap(tt.want)
-			gotSorted := sortMap(gotMap)
 
-			fmt.Println("Got type:", gotSorted)   // To check
-			fmt.Println("Want type:", wantSorted) // To check
+			if !tt.wantErr {
+				gotValue := reflect.ValueOf(got)
+				wantValue := reflect.ValueOf(tt.want)
 
-			for key, value := range wantSorted {
-				gotValue, exists := gotSorted[key]
-				if !exists || !reflect.DeepEqual(gotValue, value) {
-					t.Errorf("jwt_decode() = %v, want %v", gotSorted, wantSorted)
-					return
+				if !reflect.DeepEqual(gotValue.Interface(), wantValue.Interface()) {
+					t.Errorf("jwt_decode() = %v, want %v", gotValue.Interface(), wantValue.Interface())
 				}
 			}
-
 		})
 	}
 }
-
-func sortMap(m map[string]interface{}) map[string]interface{} {
-	keys := make([]string, 0, len(m))
-	for k := range m {
-		keys = append(keys, k)
-	}
-	sort.Strings(keys)
-
-	result := make(map[string]interface{}, len(m))
-	for _, k := range keys {
-		result[k] = m[k]
-	}
-	return result
-}
diff --git a/pkg/scratch/scratch_test.go b/pkg/scratch/scratch_test.go
index f242c50..e0e4406 100644
--- a/pkg/scratch/scratch_test.go
+++ b/pkg/scratch/scratch_test.go
@@ -45,6 +45,7 @@ func TestGetFormJWTToken(t *testing.T) {
 		wantErr bool
 	}{
 		{
+			name: "positive case - passing correct arguement",
 			args: args{[]any{"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOjIyNDEwODE1MzksIm5iZiI6MTUxNDg1MTEzOSwicm9sZSI6Imd1ZXN0Iiwic3ViIjoiWVd4cFkyVT0ifQ.ja1bgvIt47393ba_WbSBm35NrUhdxM4mOVQN8iXz8lk", "c2VjcmV0"}},
 			want: map[string]interface{}{
 				"header": map[string]interface{}{
@@ -61,6 +62,14 @@ func TestGetFormJWTToken(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		// Negative test case: passing incorrect arguments
+		{
+			name: "negative case - incorrect arguments",
+			args: args{[]any{"invalid_jwt_token", "c2VjcmV0"}},
+			want: nil,
+			// Expecting an error because of the invalid JWT token
+			wantErr: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -87,6 +96,7 @@ func TestGetFormJWTTokenPayload(t *testing.T) {
 		wantErr bool
 	}{
 		{
+			name: "Positive case",
 			args: args{[]any{"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOjIyNDEwODE1MzksIm5iZiI6MTUxNDg1MTEzOSwicm9sZSI6Imd1ZXN0Iiwic3ViIjoiWVd4cFkyVT0ifQ.ja1bgvIt47393ba_WbSBm35NrUhdxM4mOVQN8iXz8lk", "c2VjcmV0"}},
 			want: map[string]interface{}{
 				"exp":  2.241081539e+09,
@@ -96,6 +106,14 @@ func TestGetFormJWTTokenPayload(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		// Negative test case: passing incorrect arguments
+		{
+			name: "negative case - incorrect arguments",
+			args: args{[]any{"invalid_jwt_token", "c2VjcmV0"}},
+			want: nil,
+			// Expecting an error because of the invalid JWT token
+			wantErr: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {