fix policy dashboard

Signed-off-by: Frank Jogeleit <[email protected]>

Author: fjogeleit

backend/pkg/service/service.go

@@ -82,13 +82,15 @@ func (s *Service) PolicyDetails(ctx context.Context, cluster, source, policy str
 	if plugin, ok := s.plugin(cluster, source); ok {
 		g.Go(func() error {
 			details, err = plugin.GetPolicy(ctx, policy)
-			zap.L().Error(
-				"failed to load policy details from plugin",
-				zap.String("cluster", cluster),
-				zap.String("source", source),
-				zap.String("policy", policy),
-				zap.Error(err),
-			)
+			if err != nil {
+				zap.L().Error(
+					"failed to load policy details from plugin",
+					zap.String("cluster", cluster),
+					zap.String("source", source),
+					zap.String("policy", policy),
+					zap.Error(err),
+				)
+			}
 
 			return nil
 		})

frontend/modules/core/components/policy/Details.vue

@@ -59,11 +59,11 @@
       <template v-if="policy.additional && policy.additional.length">
         <v-col v-for="details in policy.additional" :cols="detailsCols">
           <v-card :title="details.title">
-            <v-container>
+            <v-container fluid>
               <template v-for="item in details.items" :key="item.value">
                 <v-row class="top-border" v-if="item.value">
-                  <v-col cols="6" class="font-weight-bold" v-if="item.title">{{ item.title }}</v-col>
-                  <v-col cols="6">{{ item.value }}</v-col>
+                  <v-col :cols="detailsLabelCols.label" class="font-weight-bold" v-if="item.title">{{ item.title }}</v-col>
+                  <v-col :cols="detailsLabelCols.value">{{ item.value }}</v-col>
                 </v-row>
               </template>
             </v-container>
@@ -134,12 +134,13 @@ const expand = ref(false)
 const descriptionHeight = computed(() => expand.value ? undefined : '200px')
 
 const detailsCols = computed(() => {
-  const cols = Math.ceil(12 / props.policy.additional.length)
-  if (cols === 12) {
-    return 5
-  }
+  return Math.ceil(12 / props.policy.additional.length)
+})
+
+const detailsLabelCols = computed(() => {
+  if (detailsCols.value === 12) return ({ label: 2, value: 10 })
 
-  return cols
+  return { label: 6, value: 6 }
 })
 </script>
 

frontend/modules/core/components/policy/StatusCharts.vue

@@ -3,15 +3,15 @@
     <v-col cols="12" md="4">
       <v-card>
         <v-card-text>
-          <GraphStatusDistribution :data="data.charts.findings" />
+          <GraphCountDistribution :data="data.charts.findings" />
         </v-card-text>
       </v-card>
     </v-col>
     <v-col cols="12" md="8">
       <v-card style="height: 100%">
         <v-card-text style="height: 100%; position: relative;">
-          <GraphStatusPerNamespace v-if="showExpanded" :data="data.charts.namespaceScope.complete" />
-          <GraphStatusPerNamespace v-else :data="data.charts.namespaceScope.preview" />
+          <GraphCountPerNamespace v-if="showExpanded" :data="data.charts.namespaceScope.complete" />
+          <GraphCountPerNamespace v-else :data="data.charts.namespaceScope.preview" />
           <v-btn v-if="hasPreview" variant="outlined" size="small" @click="expand = !expand" style="position: absolute; bottom: 10px; right: 10px;" rounded="0">
             <span v-if="showExpanded">Show preview</span>
             <span v-else>Show Complete List</span>