From 2f1e5d878fe4de8b8f55bc8accb9474b447dd51a Mon Sep 17 00:00:00 2001 From: Vishal Choudhary Date: Thu, 4 Jul 2024 13:48:21 +0530 Subject: [PATCH] fix: reports-server restart in default installation (#152) Signed-off-by: Vishal Choudhary --- Makefile | 4 ++-- charts/reports-server/README.md | 4 ++-- charts/reports-server/values.yaml | 3 ++- config/install-inmemory.yaml | 3 ++- config/install.yaml | 3 ++- 5 files changed, 10 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 4e10b2a..e2b0e54 100644 --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ REGISTER_GEN := $(TOOLS_DIR)/register-gen OPENAPI_GEN := $(TOOLS_DIR)/openapi-gen CODE_GEN_VERSION := v0.28.0 KIND := $(TOOLS_DIR)/kind -KIND_VERSION := v0.20.0 +KIND_VERSION := v0.23.0 KO := $(TOOLS_DIR)/ko KO_VERSION := v0.14.1 HELM := $(TOOLS_DIR)/helm @@ -192,7 +192,7 @@ verify-codegen: codegen ## Verify all generated code and docs are up to date # KIND # ######## -KIND_IMAGE ?= kindest/node:v1.28.0 +KIND_IMAGE ?= kindest/node:v1.30.0 KIND_NAME ?= kind .PHONY: kind-create diff --git a/charts/reports-server/README.md b/charts/reports-server/README.md index ed45ea5..6da2e69 100644 --- a/charts/reports-server/README.md +++ b/charts/reports-server/README.md @@ -42,8 +42,8 @@ helm install reports-server --namespace reports-server --create-namespace report | podAnnotations | object | `{}` | Pod annotations | | podSecurityContext | object | `{"fsGroup":2000}` | Pod security context | | securityContext | object | See [values.yaml](values.yaml) | Container security context | -| livenessProbe | object | `{"failureThreshold":3,"httpGet":{"path":"/livez","port":"https","scheme":"HTTPS"},"periodSeconds":10}` | Liveness probe | -| readinessProbe | object | `{"failureThreshold":3,"httpGet":{"path":"/readyz","port":"https","scheme":"HTTPS"},"initialDelaySeconds":20,"periodSeconds":10}` | Readiness probe | +| livenessProbe | object | `{"failureThreshold":3,"httpGet":{"path":"/livez","port":"https","scheme":"HTTPS"},"initialDelaySeconds":90,"periodSeconds":10}` | Liveness probe | +| readinessProbe | object | `{"failureThreshold":3,"httpGet":{"path":"/readyz","port":"https","scheme":"HTTPS"},"initialDelaySeconds":100,"periodSeconds":10}` | Readiness probe | | resources.limits | string | `nil` | Container resource limits | | resources.requests | string | `nil` | Container resource requests | | autoscaling.enabled | bool | `false` | Enable autoscaling | diff --git a/charts/reports-server/values.yaml b/charts/reports-server/values.yaml index 8ba49ef..87e7193 100644 --- a/charts/reports-server/values.yaml +++ b/charts/reports-server/values.yaml @@ -81,6 +81,7 @@ securityContext: # -- Liveness probe livenessProbe: failureThreshold: 3 + initialDelaySeconds: 90 periodSeconds: 10 httpGet: path: /livez @@ -89,7 +90,7 @@ livenessProbe: # -- Readiness probe readinessProbe: - initialDelaySeconds: 20 + initialDelaySeconds: 100 failureThreshold: 3 periodSeconds: 10 httpGet: diff --git a/config/install-inmemory.yaml b/config/install-inmemory.yaml index 98ab3f9..734d1f0 100644 --- a/config/install-inmemory.yaml +++ b/config/install-inmemory.yaml @@ -198,6 +198,7 @@ spec: path: /livez port: https scheme: HTTPS + initialDelaySeconds: 90 periodSeconds: 10 readinessProbe: failureThreshold: 3 @@ -205,7 +206,7 @@ spec: path: /readyz port: https scheme: HTTPS - initialDelaySeconds: 20 + initialDelaySeconds: 100 periodSeconds: 10 resources: limits: null diff --git a/config/install.yaml b/config/install.yaml index cbc71d4..0c4bd0d 100644 --- a/config/install.yaml +++ b/config/install.yaml @@ -293,6 +293,7 @@ spec: path: /livez port: https scheme: HTTPS + initialDelaySeconds: 90 periodSeconds: 10 readinessProbe: failureThreshold: 3 @@ -300,7 +301,7 @@ spec: path: /readyz port: https scheme: HTTPS - initialDelaySeconds: 20 + initialDelaySeconds: 100 periodSeconds: 10 resources: limits: null