Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name not displayed on Winger button for restored windows #26

Open
supersaiyansubtlety opened this issue Aug 24, 2023 · 8 comments
Open

Comments

@supersaiyansubtlety
Copy link

  • name is still there if I click on the Winger button
  • name displays fine for windows created in current session
  • name also displays fine after closing and re-opening an issue window with using History > Recently closed windows

Not sure if this is related to #20 because I'm using the builtin Firefox session restore, and it's the name on the Winger button not the actual window name.

Another extension could still be involved. I have Tabs Session Manager installed, but I'm restoring using the builtin History > Restore previous session (it used to restore the names on the Winger button, sorry I've had this issue a while so I'm not sure when it started).

Note that I'm actually using LibreWolf, but I doubt that matters.

@supersaiyansubtlety
Copy link
Author

On Windows 10

@l10nelw
Copy link
Owner

l10nelw commented Oct 8, 2023

Can you check if this is still an issue in the latest verson 2.4.0?

@supersaiyansubtlety
Copy link
Author

It is still an issue

@supersaiyansubtlety
Copy link
Author

supersaiyansubtlety commented Nov 12, 2023

A little more info:

  • One window seems to always have its name displayed correctly (I think it's the first one to reopen but it's hard to say).
  • Sometime the names do display correctly for all windows , I think when few windows are being restored (names worked just now when restoring 6 windows, they frequently don't work when restoring 10+ windows). nvm, basically the same 6 window session restored with names not displayed.

@l10nelw
Copy link
Owner

l10nelw commented Nov 13, 2023

Thanks @supersaiyansubtlety. FYI I've switched to using my Windows 10 machine for the past few weeks, so far I haven't encountered the bug myself unfortunately.

@supersaiyansubtlety
Copy link
Author

So it could just be coincidence, since the issue is inconsistent, but:
When winger auto-updated to 2.5.0, the names displayed properly on the launch when the update occurred, for three different instances.

@supersaiyansubtlety
Copy link
Author

I think this is fixed in 2.8.0, perhaps because of the new label regex feature.

I haven't noticed it since setting label regex.

I also restarted a few times without regex to test and didn't see this issue.

@supersaiyansubtlety
Copy link
Author

This happened again on a browser profile where I hadn't set any regex.

I added .* as regex and it immediately fixed itself, so there is at least a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants