Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete rewrite #63

Open
3 tasks
l3lackShark opened this issue Mar 31, 2021 · 3 comments
Open
3 tasks

Complete rewrite #63

l3lackShark opened this issue Mar 31, 2021 · 3 comments

Comments

@l3lackShark
Copy link
Owner

l3lackShark commented Mar 31, 2021

Original architectural structure decisions were made back in the day when I was just starting coding and so it really is a mess. Was honestly surprised how stable it became after so many crutches and polishing attempts.

Current flaws:

  • Blocking loops on each goroutine instead of a sequential operations/channels
  • Asynchronous websocket stream as a result of ^
  • Cgo calls mix within go calls/multiple instances of pp calculators
  • Bad error handling (non-existent in some cases)
  • .ini config was a mistake after all, we probably should move to something like json/yaml
  • Mix of {log/pp/fmt}.Println calls for no reason
  • Global variables mess across packages
  • Non-Existent debug logging (besides mem package)

To combat that until it's too late I made a decision to rewrite most of the project.

The progress will be updated below:

  • replace a mess that's also known as a pp package with https://github.com/l3lackShark/cgoppai
  • rewrite memory package to the point that it's consistent with the way we read memory and send payload to web
  • GUI?
@l3lackShark l3lackShark pinned this issue Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@l3lackShark and others