Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Restructure ridge test for different dataset cases #33

Open
agoscinski opened this issue Mar 6, 2023 · 0 comments
Open

Restructure ridge test for different dataset cases #33

agoscinski opened this issue Mar 6, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@agoscinski
Copy link
Collaborator

We have certain tests in TestRidge which only work with when n_features << n_samples, so we have two data sets we are testing on. At the moment this is not so visible in the code, because we overwrite the same parameter names. We could choose different names for the parameters or pack them in a dictionary with different names. We could also use pytest fixtures for this which has the additional benefit to reduce code repetition since we do almost in every test:

        # Create input values
        X_arr = self.rng.random([2, num_targets, num_properties])
        y_arr = self.rng.random([2, num_targets, 1])
        alpha_arr = np.ones([2, 1, num_properties])
        sw_arr = np.ones([2, num_targets, 1])
@agoscinski agoscinski added the documentation Improvements or additions to documentation label Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant