Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Change ridge's cholesky solver from scipy.linalg.solve(assume_a='pos') to scipy.linalg.cholesky #36

Open
agoscinski opened this issue Mar 8, 2023 · 0 comments

Comments

@agoscinski
Copy link
Collaborator

In PR #31 we using scipy.linalg.solve with argument assuma_a='pos', to reproduce this with torch however we should use scipy.linalg.cholesky so we can replace it later with equistore operations. This needs a bit additional work (how some additional postprocessing, checking if the scipy and torch solvers bring similar accuracy), so we deal with this in a new PR.

@agoscinski agoscinski added this to the Full TorchScript support milestone Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant