Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

torch.Tensor support for methods in numpy submodule #63

Open
agoscinski opened this issue Sep 15, 2023 · 0 comments
Open

torch.Tensor support for methods in numpy submodule #63

agoscinski opened this issue Sep 15, 2023 · 0 comments

Comments

@agoscinski
Copy link
Collaborator

In #62 we introduce tox testing environments for metatensor-core with numpy arrays and with torch tenors. For now in tests/equisolve_tests/numpy/utilities.py we set use_torch to False, so all tests are not run using numpy as array backend. But we probably also want to support torch tensors for modules like Ridge and SparseKRR. Internally everything will be converted to numpy arrays (which we eventually change also at some point).

This would go hand in hand with a renaming of the numpy submodule to something less specific. One could use the term shallow for shallow ML methods like linear and kernel models. Or we split it up into kernel_ridge and linear_model as scikit-learn does it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant