Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to installation docs #116

Open
sirmarcel opened this issue Apr 29, 2024 · 3 comments
Open

Improvements to installation docs #116

sirmarcel opened this issue Apr 29, 2024 · 3 comments

Comments

@sirmarcel
Copy link

Hi there, I've just gone through the process of installing sphericart with CUDA for the first time and I'd suggest some minor improvements to the related docs:

Additionally, the docs on building the C++ code could benefit from:

  • Mention that libtorch is a requirement and where it should be exported (CMAKE_PREFIX_PATH)
  • Mention the need for cmake to be at least version 3.24 (otherwise the detection of which target GPU to target fails)

Overall, it'd be a good idea to make it possible to build for non-present GPUs, but this can't be accomplished by slightly polishing the docs. :)

@nickjbrowning
Copy link
Collaborator

nickjbrowning commented Apr 29, 2024

Hello,

Many thanks for reporting this and providing your observations.

It's usually recommended to build software on the compute nodes, rather than the login nodes, at least this is what we recommend at CSCS. I will however investigate adding in a CMake variable where you can set the gencode and archcode manually, so you can choose that sphericart is built for a given architecture (or potentially a list of).

I'll create a PR tomorrow that addresses the above as well as the RAM issue (and modify the necessary documentation accordingly!)

@sirmarcel
Copy link
Author

Thank you! Very impressed with the responsiveness here :)

@ceriottm
Copy link
Contributor

ceriottm commented Aug 7, 2024

Hello! @nickjbrowning did this PR actually happen? Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants