Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waypoint preview does not work #554

Open
ast261 opened this issue Mar 8, 2025 · 14 comments · May be fixed by #556
Open

Waypoint preview does not work #554

ast261 opened this issue Mar 8, 2025 · 14 comments · May be fixed by #556
Assignees
Milestone

Comments

@ast261
Copy link

ast261 commented Mar 8, 2025

When pressing "open file" in the Waypoint list, nothing happens.
Android: 13

Possible solution:
https://cketti.de/2020/09/03/avoid-intent-resolveactivity/

-                                       if (intent.resolveActivity(getPackageManager()) != null) {
+                                       try {
                                                startActivity(intent);
+                                       } catch (ActivityNotFoundException e) {
                                        }
                                }
                                alert.dismiss();

@miltonials
Copy link
Member

Hi, @ast261 !😄
Thank you for your report; it is very valuable!
Could you confirm whether this issue occurs when trying to open a photo, an audio file, or both?

Note: If your device doesn’t have an audio player installed, it might not be able to play audio files. The same applies to photos, although most Android devices typically have a default gallery app.

We should consider adding a message to inform users about this.
CC. @Andyporras @Kevin-Salazar-itcr @FR3DD221

@ast261 ast261 changed the title Waypoint preview does not wok Waypoint preview does not work Mar 9, 2025
@ast261
Copy link
Author

ast261 commented Mar 9, 2025

"Could you confirm whether this issue occurs when trying to open a photo, an audio file, or both?"

Only when opening a photo.

@Andyporras
Copy link
Contributor

hello @ast261 , what photo application do you have on your cell phone?

@ast261
Copy link
Author

ast261 commented Mar 9, 2025

Android 13 (AICP): org.lineageos.aperture
Android 14 (stock ROM): com.motorola.camera3

@Andyporras
Copy link
Contributor

could you download the Google photo application? because it works with that application, at least in the tests we did, it worked with that application.

@Andyporras
Copy link
Contributor

Android 13 (AICP): org.lineageos.aperture Android 14 (stock ROM): com.motorola.camera3

I think you misunderstood me, I mean photo gallery application.

@Andyporras
Copy link
Contributor

the aperture app does not work to view photos, I think that is the problem with it, because on Android 15 it does not work with that app either, try to try with Google photos or gallery - photo gallery, album or the native gallery app of the device. I tried it with those and it worked for me or any of the apps that comes out in this picture.

Image

@ast261
Copy link
Author

ast261 commented Mar 9, 2025

Android 13 (AICP): org.lineageos.aperture Android 14 (stock ROM): com.motorola.camera3

I think you misunderstood me, I mean photo gallery application.

Ah, ok.
It's not working with Google Photo gallery app.

Nevertheless, every combination of camera- and gallery-apps work fine with my fix above.

@ast261
Copy link
Author

ast261 commented Mar 9, 2025

the aperture app does not work to view photos

Correct. I referenced camera apps above. Sorry.

@Andyporras
Copy link
Contributor

Nevertheless, every combination of camera- and gallery-apps work fine with my fix above.

if you can do the pr, I would appreciate it and I would approve it and if you can't I can do the pr with what you mention.

@ast261
Copy link
Author

ast261 commented Mar 9, 2025

I have not done a PR, because my catch clause above is empty (I have restricted Android knowledge).
You know better how and what message to display in this case.

@miltonials
Copy link
Member

I tested both the current code and the suggested change on Android 7.1.1, 12, 13, 14 and 15.

Current code Suggested change
Image Image

Unfortunately, I wasn’t able to reproduce the issue—it worked fine for me in both cases. However, I still think it’s a good idea to apply the change. Since Android 11, resolveActivity is likely to return null because it may not find all applications capable of handling the intent (see package visibility).

Additionally, the current code asks for an application to handle the intent twice. First with resolveActivity, then with startActivity.

@ast261 mentioned that "..., every combination of camera- and gallery-apps work fine with my fix above". This change should resolve the issue, avoiding redundant intent handling steps in the functionality. @Andyporras, can you take care of it?

@Andyporras
Copy link
Contributor

Andyporras commented Mar 9, 2025

ready, I already made the pr with the change, I would appreciate if you could check the pr and corroborate that the change works. The pr is #556

@Andyporras Andyporras linked a pull request Mar 9, 2025 that will close this issue
@miltonials miltonials linked a pull request Mar 9, 2025 that will close this issue
@miltonials
Copy link
Member

miltonials commented Mar 9, 2025

@ast261, this zip file contains an APK with changes. You can use it while waiting for the new update to be released.

debug-20250309-2330.zip

@miltonials miltonials added this to the 2025.07 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants