-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waypoint preview does not work #554
Comments
Hi, @ast261 !😄 Note: If your device doesn’t have an audio player installed, it might not be able to play audio files. The same applies to photos, although most Android devices typically have a default gallery app. We should consider adding a message to inform users about this. |
"Could you confirm whether this issue occurs when trying to open a photo, an audio file, or both?" Only when opening a photo. |
hello @ast261 , what photo application do you have on your cell phone? |
Android 13 (AICP): org.lineageos.aperture |
could you download the Google photo application? because it works with that application, at least in the tests we did, it worked with that application. |
I think you misunderstood me, I mean photo gallery application. |
the aperture app does not work to view photos, I think that is the problem with it, because on Android 15 it does not work with that app either, try to try with Google photos or gallery - photo gallery, album or the native gallery app of the device. I tried it with those and it worked for me or any of the apps that comes out in this picture. |
Ah, ok. Nevertheless, every combination of camera- and gallery-apps work fine with my fix above. |
Correct. I referenced camera apps above. Sorry. |
if you can do the pr, I would appreciate it and I would approve it and if you can't I can do the pr with what you mention. |
I have not done a PR, because my catch clause above is empty (I have restricted Android knowledge). |
I tested both the current code and the suggested change on Android 7.1.1, 12, 13, 14 and 15.
Unfortunately, I wasn’t able to reproduce the issue—it worked fine for me in both cases. However, I still think it’s a good idea to apply the change. Since Android 11, Additionally, the current code asks for an application to handle the intent twice. First with @ast261 mentioned that "..., every combination of camera- and gallery-apps work fine with my fix above". This change should resolve the issue, avoiding redundant intent handling steps in the functionality. @Andyporras, can you take care of it? |
ready, I already made the pr with the change, I would appreciate if you could check the pr and corroborate that the change works. The pr is #556 |
@ast261, this zip file contains an APK with changes. You can use it while waiting for the new update to be released. |
When pressing "open file" in the Waypoint list, nothing happens.
Android: 13
Possible solution:
https://cketti.de/2020/09/03/avoid-intent-resolveactivity/
The text was updated successfully, but these errors were encountered: