Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseProviderDriver sets wrong host for local resources #1282

Open
Bastian-Krause opened this issue Oct 12, 2023 · 2 comments
Open

BaseProviderDriver sets wrong host for local resources #1282

Bastian-Krause opened this issue Oct 12, 2023 · 2 comments
Assignees
Labels

Comments

@Bastian-Krause
Copy link
Member

Since #1249, local resources have:

self.host = "localhost"

This is wrong because host should also reflect the DUT's perspective.

@Bastian-Krause
Copy link
Member Author

Because the DUT might not be able to resolve what hostname() returns, the local resource should also have an explicit host parameter.

@Bastian-Krause
Copy link
Member Author

Bastian-Krause commented Nov 28, 2023

I'm wondering if local provider resources even make sense with the suggested change?

And instead of having them with the "Remote" prefix, wouldn't it make more sense to prefix them with "Network" (NetworkHTTPProvider, NetworkTFTPProvider, NetworkNFSProvider)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant