Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Validate config before restarting rke2 #188

Open
mueller-ma opened this issue Jan 31, 2024 · 1 comment
Open

feature: Validate config before restarting rke2 #188

mueller-ma opened this issue Jan 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mueller-ma
Copy link
Contributor

Summary

I had the following invalid ansible-role-rke2 config which lead to a broken /etc/rancher/rke2/config.yaml on the server:

rke2_server_options:
  service-node-port-range: 20000-32767

Maybe the config.yaml can be validated before trying to restart any service?

Issue Type

Feature Idea
@mueller-ma mueller-ma added the enhancement New feature or request label Jan 31, 2024
@mueller-ma
Copy link
Contributor Author

@MonolithProjects Would you accept an PR that installs yamllint on the node and uses that to validate /etc/rancher/rke2/config.yaml? It can be made optional to avoid the installation of yamllint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mueller-ma