From 5b305b225f7c211a38425a0ba1da5ae0a2d6d57a Mon Sep 17 00:00:00 2001 From: Kyujin Cho Date: Sun, 7 Apr 2024 22:01:22 +0900 Subject: [PATCH] fix: notarization not working (#2320) --- .github/workflows/package.yml | 1 + app-packager.js | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml index b59bda5ff0..82e69d8099 100644 --- a/.github/workflows/package.yml +++ b/.github/workflows/package.yml @@ -27,6 +27,7 @@ jobs: run: make all env: BAI_APP_SIGN: 1 + BAI_APP_SIGN_APPLE_TEAM_ID: ${{ secrets.BAI_APP_SIGN_APPLE_TEAM_ID }} BAI_APP_SIGN_APPLE_ID: ${{ secrets.BAI_APP_SIGN_APPLE_ID }} BAI_APP_SIGN_APPLE_ID_PASSWORD: ${{ secrets.BAI_APP_SIGN_APPLE_ID_PASSWORD }} BAI_APP_SIGN_IDENTITY: ${{ secrets.BAI_APP_SIGN_IDENTITY }} diff --git a/app-packager.js b/app-packager.js index 8eb430a000..a8fc8351a9 100644 --- a/app-packager.js +++ b/app-packager.js @@ -9,6 +9,7 @@ program program.addOption((new Option('--do-sign', 'Code sign created application with Apple Developer Identity.').env('BAI_APP_SIGN'))) program.addOption((new Option('--sign-apple-id ')).env('BAI_APP_SIGN_APPLE_ID')) program.addOption((new Option('--sign-apple-id-password ')).env('BAI_APP_SIGN_APPLE_ID_PASSWORD')) +program.addOption((new Option('--sign-apple-team-id ')).env('BAI_APP_SIGN_APPLE_TEAM_ID')) program.addOption((new Option('--sign-identity ')).env('BAI_APP_SIGN_IDENTITY')) program.addOption((new Option('--sign-keychain ')).env('BAI_APP_SIGN_KEYCHAIN')) @@ -88,6 +89,7 @@ if (selectedOptions.doSign === true && (args[0] === 'mas' || args[0] === 'darwin options.osxNotarize = { appleId: selectedOptions.signAppleId, appleIdPassword: selectedOptions.signAppleIdPassword, + teamId: selectedOptions.signAppleTeamId, } console.log(clc.blue('\n[BUILD]') + ` Signing package with identity ${clc.yellow(options.osxSign.identity)}`);