feat: user can open a session detail panel in notifications #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Nov 18, 2024
This was referenced Nov 18, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
force-pushed
the
feature/webui-link-and-navigate-component
branch
from
4b2abdc to
d89a170
Compare
yomybaby
force-pushed
the
feature/session-detail-panel-in-notifications
branch
from
f044721 to
7652afb
Compare
yomybaby
force-pushed
the
feature/webui-link-and-navigate-component
branch
from
d89a170 to
39796fa
Compare
yomybaby
force-pushed
the
feature/session-detail-panel-in-notifications
branch
from
7652afb to
2e56e7e
Compare
Merge activity
|
Resovles #2857  **Changes:** - Preserves query parameters when redirecting from root to `/job` path - Simplifies WebUINavigate component by extracting query parameters directly from the URL - Adds "See Detail" notification with navigation link after session creation **Impact:** - Users will maintain their URL parameters when being redirected from the root path - Session creation now provides a direct link to view session details via notification - Improves navigation flow between different sections of the application **Testing Steps:** 1. Create a new session 2. Confirm "See Details" notification appears with correct session link 3. Click "See Details" in session creation notification. 4. Confirm a session detail panel is opened
yomybaby
force-pushed
the
feature/webui-link-and-navigate-component
branch
from
39796fa to
aa466b1
Compare
yomybaby
force-pushed
the
feature/session-detail-panel-in-notifications
branch
from
2e56e7e to
504b649
Compare
Base automatically changed from
feature/webui-link-and-navigate-component
to
main
November 20, 2024 07:01
graphite-app
bot
deleted the
feature/session-detail-panel-in-notifications
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resovles #2857
Changes:
/jobpathImpact:
Testing Steps: