Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up vfolder statuses #1915

Open
1 task done
fregataa opened this issue Feb 16, 2024 · 2 comments
Open
1 task done

Clean up vfolder statuses #1915

fregataa opened this issue Feb 16, 2024 · 2 comments
Assignees
Labels
comp:manager Related to Manager component
Milestone

Comments

@fregataa
Copy link
Member

fregataa commented Feb 16, 2024

This is a follow-up to #1892 and #713.

One entity should have only one state machine.
Let's leave VFolderOperationStatus only.

  • Merge VFolderAccessStatus into VFolderOperationStatus
  • Change or merge VFolderFilterStatusFailed, VFolderFilterStatusNotAvailable to VFolderOperationForbidden or VFolderNotFound and update error message for client
  • Allow ensure_vfolder_status to get multiple statuses

Tasks

  1. area:docs comp:manager size:L type:bug
    kyujin-cho
@fregataa fregataa added this to the 24.03 milestone Feb 16, 2024
@fregataa fregataa added the comp:manager Related to Manager component label Feb 16, 2024
@achimnol
Copy link
Member

achimnol commented Apr 26, 2024

VFolderAccessStatus is an alias mapping to VFolderOperationStatus.
#2072 will rename it to make this clear, and ensure_vfolder_status() will be refactored to a decorator.

@achimnol
Copy link
Member

Let's clarify the meaning or future implementation plan of VFolderOperationStatus.MOUNTED, or remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component
Projects
None yet
Development

No branches or pull requests

3 participants