Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client SDK's missing parts and mistakes #3207

Open
achimnol opened this issue Dec 5, 2024 · 0 comments
Open

Improve client SDK's missing parts and mistakes #3207

achimnol opened this issue Dec 5, 2024 · 0 comments
Labels
comp:client Related to Client component
Milestone

Comments

@achimnol
Copy link
Member

achimnol commented Dec 5, 2024

There are several issues found when I tried to use the client SDK for model services and @leksikov tried to write Helmsman training dataset for the model service CLI.

Regarding #3202, there is a general problem with existing ComputeSession and InferenceSession classes with from_session_id() classmethod. Since the instance returned by from_session_id() does not have any other valid attributes before making an actual GET /session/{session_name_or_id} manager API request, trying to access .service_ports, .session_name would fail. As they are just plain self attributes and we cannot make property methods asynchronous, we should add an explicit async method to fill the instance attributes.

Related pull requests

@achimnol achimnol added the comp:client Related to Client component label Dec 5, 2024
@achimnol achimnol added this to the 24.09 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:client Related to Client component
Projects
None yet
Development

No branches or pull requests

1 participant