You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several issues found when I tried to use the client SDK for model services and @leksikov tried to write Helmsman training dataset for the model service CLI.
Regarding #3202, there is a general problem with existing ComputeSession and InferenceSession classes with from_session_id() classmethod. Since the instance returned by from_session_id() does not have any other valid attributes before making an actual GET /session/{session_name_or_id} manager API request, trying to access .service_ports, .session_name would fail. As they are just plain self attributes and we cannot make property methods asynchronous, we should add an explicit async method to fill the instance attributes.
There are several issues found when I tried to use the client SDK for model services and @leksikov tried to write Helmsman training dataset for the model service CLI.
Regarding #3202, there is a general problem with existing
ComputeSession
andInferenceSession
classes withfrom_session_id()
classmethod. Since the instance returned byfrom_session_id()
does not have any other valid attributes before making an actualGET /session/{session_name_or_id}
manager API request, trying to access.service_ports
,.session_name
would fail. As they are just plainself
attributes and we cannot makeproperty
methods asynchronous, we should add an explicit async method to fill the instance attributes.Related pull requests
The text was updated successfully, but these errors were encountered: