Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Samples" and "current_samples" can't be used by concurrent users #580

Open
SamuelNicaise opened this issue Apr 25, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@SamuelNicaise
Copy link
Collaborator

SamuelNicaise commented Apr 25, 2023

When multiple users use the same database concurrently on a shared network drive:

Issue with "samples" source:

  • user A selects samples with the sample modules
  • when user B selects samples --> selected variant lists is changed for user A without obvious visual cues except total number of variants

Same issue with "current_samples" source:

  • user A double clicks on a sample, a genotype columns appears and "current_samples" is changed
  • when user B double clicks on a sample: for user A, the genotype column stays the same but variant selection changed, without obvious visual cues except total number of variants

Currently, we deal with the issue by recommanding users to use manually created sources instead of those features.

@antonylebechec antonylebechec added bug Something isn't working enhancement New feature or request labels May 10, 2023
SamuelNicaise added a commit that referenced this issue Nov 15, 2023
- Add 'selected_samples' state to prevent Genotype based queries from failing due to too many SQLite clause terms
- Pass it to querybuilder
- Log message instead of letting the unrecoverable error occur
- Fix group by widget related issues
- Fix report related issues
- Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants