-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lacework-agent v6.3.0: anonymizeIncoming
is listed as optional but chart fails if not included in the values
#169
Comments
Hell @laconc, can you share the |
This is driving me nuts right now
My values file has
I am aliasing the dependent upstream chart to lacework I can confirm the workaround above works
But id rather not include this at all in my values file |
Chris, my working values right now are:
|
@laconc, thanks for providing the values that work for you. @lorelei-rupp-imprivata, sorry that this is causing you pain! This is definitely an area where we can improve. I'm going to try and see if there's a good fix for this. |
@cirego I think the biggest issue was there was no documentation and the docs said it was optional so I was scratching my head as to how to get it to template out. I had to go into the schema json to understand what it was expecting so I could try a few things out, wish I had done a gitissue search sooner to find the workaround |
Neither anonymizeIncoming or netmask should be required, right? I expect the documentation to be consistent with the schema (ideally, the doc should be generated from the schema?), and that any changes to required properties are called-out in the release notes. |
@joebowbeer this says its optional https://github.com/lacework/helm-charts/blob/main/lacework-agent/values.yaml#L54-L57 which is why I was so confused |
Looks like .laceworkConfig.anonymizeIncoming was introduced in v6.3.0 as an optional field, as well as the child value
.netmask
. Unfortunately, attempting to deploy it results inI can get past it by including the
.laceworkConfig.anonymizeIncoming
key with a null value, in my values.I'm unable to diagnose it further at the moment and will be moving forward with that workaround. If I was debugging this, I'd check to see if there's a conflict with
values.yaml
and.netmask
being set as a required value of.laceworkConfig.anonymizeIncoming
.The text was updated successfully, but these errors were encountered: