Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lacework-agent v6.3.0: anonymizeIncoming is listed as optional but chart fails if not included in the values #169

Open
laconc opened this issue Feb 21, 2023 · 7 comments

Comments

@laconc
Copy link

laconc commented Feb 21, 2023

Looks like .laceworkConfig.anonymizeIncoming was introduced in v6.3.0 as an optional field, as well as the child value .netmask. Unfortunately, attempting to deploy it results in

Error: values don't meet the specifications of the schema(s) in the following chart(s):
lacework-agent:
- laceworkConfig.anonymizeIncoming: netmask is required

I can get past it by including the .laceworkConfig.anonymizeIncoming key with a null value, in my values.

I'm unable to diagnose it further at the moment and will be moving forward with that workaround. If I was debugging this, I'd check to see if there's a conflict with values.yaml and .netmask being set as a required value of .laceworkConfig.anonymizeIncoming.

@cirego
Copy link
Contributor

cirego commented Feb 23, 2023

Hell @laconc, can you share the values.yaml and/or --set options that you are using? Did you specify the anonymizeIncoming field in your values?

@lorelei-rupp-imprivata
Copy link

lorelei-rupp-imprivata commented Feb 23, 2023

This is driving me nuts right now
I just get

Error: values don't meet the specifications of the schema(s) in the following chart(s):
lacework:
- laceworkConfig.anonymizeIncoming: netmask is required

My values file has

lacework:
  laceworkConfig:
    anonymizeIncoming:
      netmask:

I am aliasing the dependent upstream chart to lacework

I can confirm the workaround above works

lacework:
  laceworkConfig:
    anonymizeIncoming:

But id rather not include this at all in my values file
The comments say its optional but its not

@laconc
Copy link
Author

laconc commented Feb 23, 2023

Chris, my working values right now are:

laceworkConfig:
  accessToken:
    existingSecret:
      name: lacework-secrets
      key: ACCESS_TOKEN

  anonymizeIncoming:

  kubernetesCluster: my-cluster
  env: dev

@cirego
Copy link
Contributor

cirego commented Feb 24, 2023

@laconc, thanks for providing the values that work for you.

@lorelei-rupp-imprivata, sorry that this is causing you pain! This is definitely an area where we can improve. I'm going to try and see if there's a good fix for this.

@lorelei-rupp-imprivata
Copy link

@cirego I think the biggest issue was there was no documentation and the docs said it was optional so I was scratching my head as to how to get it to template out. I had to go into the schema json to understand what it was expecting so I could try a few things out, wish I had done a gitissue search sooner to find the workaround

@joebowbeer
Copy link

Neither anonymizeIncoming or netmask should be required, right?

I expect the documentation to be consistent with the schema (ideally, the doc should be generated from the schema?), and that any changes to required properties are called-out in the release notes.

@lorelei-rupp-imprivata
Copy link

lorelei-rupp-imprivata commented Feb 24, 2023

@joebowbeer this says its optional https://github.com/lacework/helm-charts/blob/main/lacework-agent/values.yaml#L54-L57 which is why I was so confused
I figured the values file had the default and I could just leave whatever was in values.yaml and not have to set anything myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants