New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource requests and limits are not set in admission-controller chart deployment #181

Open

giepa opened this issue Mar 30, 2023 · 0 comments

giepa commented Mar 30, 2023

The deployment in the admission-controller chart, has no resource requests and limits set.

Is this intended to be left out?

I'm guessing it should be something like:

spec:
  template:
    spec:
      containers:
        - name: {{ include "admission.name" . }}
          {{- with .Values.resources }}
          resources:
            {{ toYaml . | nindent 10 | trim }}
          {{- end }}

I would be happy to open a PR

Thanks Gideon

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment