-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the valid values of required contact point nr #18
Comments
It's probably worth copying comments from the original
|
Both in this issue and a few others with a similar comment from @TimMoore, I think that at least a link to the original Adding the link (instead of copying the comment) has the advantage of guiding the user into a wider range of information. |
This PR fixes the syntax to enable `javacOptions` in each of the `sbt` modules. This fix revealed a deprecation warning in akka-grpc generated code. The consequence of this warning with the `-Werror` flag is the build of this PR will break. Unfortunately the newet `0.5.0` release of `akka-grpc` introduces other compilation errors on the generated code so at the moment we can't have a 100% error-free lagom-grpc sample.
REQUIRED_CONTACT_POINT_NR
is set on the deployment YAML file to"3"
. We could specify it must be equal or less than the replica number, otherwise the relation between the two values is not clear.https://github.com/lagom/shopping-cart-scala/blob/e30b41723922ed635a8c072ea138262147a69cea/shopping-cart-impl/src/main/resources/prod-application.conf#L36
The text was updated successfully, but these errors were encountered: