Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the valid values of required contact point nr #18

Open
ignasi35 opened this issue Feb 28, 2019 · 2 comments
Open

Document the valid values of required contact point nr #18

ignasi35 opened this issue Feb 28, 2019 · 2 comments

Comments

@ignasi35
Copy link
Contributor

REQUIRED_CONTACT_POINT_NR is set on the deployment YAML file to "3". We could specify it must be equal or less than the replica number, otherwise the relation between the two values is not clear.

https://github.com/lagom/shopping-cart-scala/blob/e30b41723922ed635a8c072ea138262147a69cea/shopping-cart-impl/src/main/resources/prod-application.conf#L36

@TimMoore
Copy link

It's probably worth copying comments from the original reference.conf for any properties in the example configuration:

https://github.com/akka/akka-management/blob/7b2892fa7a616c815541d49647555d93a52b4a69/cluster-bootstrap/src/main/resources/reference.conf#L86-L89

      # The smallest number of contact points that need to be discovered before the bootstrap process can start.
      # For optimal safety during cluster formation, you may want to set these value to the number of initial
      # nodes that you know will participate in the cluster (e.g. the value of `spec.replicas` as set in your kubernetes config.
      required-contact-point-nr = 2

@ignasi35
Copy link
Contributor Author

ignasi35 commented Mar 4, 2019

Both in this issue and a few others with a similar comment from @TimMoore, I think that at least a link to the original reference.conf (instead of copy/pasting comments) could be enough.

Adding the link (instead of copying the comment) has the advantage of guiding the user into a wider range of information.

@octonato octonato transferred this issue from lagom/shopping-cart-scala May 7, 2019
@octonato octonato changed the title Document the valid values of required contact point nr [shopping-cart] Document the valid values of required contact point nr May 7, 2019
mergify bot pushed a commit that referenced this issue May 7, 2019
octonato pushed a commit to octonato/lagom-samples that referenced this issue May 8, 2019
This PR fixes the syntax to enable `javacOptions` in each of the `sbt` modules.

This fix revealed a deprecation warning in akka-grpc generated code. The consequence of this warning with the `-Werror` flag is the build of this PR will break. Unfortunately the newet `0.5.0` release of `akka-grpc` introduces other compilation errors on the generated code so at the moment we can't have a 100% error-free lagom-grpc sample.
@octonato octonato changed the title [shopping-cart] Document the valid values of required contact point nr Document the valid values of required contact point nr May 8, 2019
@settings settings bot removed the shopping-cart label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants