Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the configuration management #36

Open
manodupont opened this issue Feb 9, 2023 · 0 comments
Open

Modify the configuration management #36

manodupont opened this issue Feb 9, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@manodupont
Copy link
Contributor

The goal would be to change the way the configuration are handled. At the moment a merge system is in place based on NODE_ENV but the system in place doesn't correctly take into account the possible fallback with environment variable. More precisely if NODE_ENV=development and ENV_TEST_XXXXX=titiand in the development.ts file configuration we have
{ test: 'toto' }

but in the parent config we do have
{ test: process.env.ENV_TEST_XXXXX }

we will have test=toto as the final merged configuration.

Describe the solution you'd like
We should refactor this solution by removing all ["development.ts", "production.ts", ...] files and just keep the parent config.ts file to remove any ambiguity or use an already working solution like convict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant