Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linking to search results #152

Open
2 tasks
daniel-eder opened this issue Mar 2, 2022 · 3 comments
Open
2 tasks

Allow linking to search results #152

daniel-eder opened this issue Mar 2, 2022 · 3 comments
Labels
todo Anyone is welcome to work on this feature

Comments

@daniel-eder
Copy link
Collaborator

daniel-eder commented Mar 2, 2022

I have not yet looked into how the search currently works, but it would be great to be able to add a search query to the URL and thus link users to search results. This could be used to e.g. give (potential) new memcode users a quick overview of the available topics with one click.

I think this feature needs two parts:

  • URL query parameters such as e.g. https://www.memcode.com/courses?query=java+for+beginners
  • A way to easily generate the query url - maybe the URL could update when enter is pressed in the search field, or even live using window.history.replaceState (not sure if react router can replace state without a reload)
@lakesare lakesare added the todo Anyone is welcome to work on this feature label Mar 2, 2022
@lakesare
Copy link
Owner

lakesare commented Mar 2, 2022

I agree, we got to have it, the way we already have /courses?categoryId=3&page=2.

@lakesare
Copy link
Owner

I think the new profile page achieves some of that functionality, e.g. now you can refer people to all of your English courses (memcode.com/users/1?categoryId=15).
Still a todo though!

@lakesare
Copy link
Owner

Price assignment (re: memcode#requesting-a-feature)

Urls for search + search by author name: $30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Anyone is welcome to work on this feature
Projects
None yet
Development

No branches or pull requests

2 participants