Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LEVM: Replace SpecId with Fork #1741

Closed
ilitteri opened this issue Jan 17, 2025 · 2 comments · Fixed by #1762
Closed

LEVM: Replace SpecId with Fork #1741

ilitteri opened this issue Jan 17, 2025 · 2 comments · Fixed by #1762
Labels
levm Lambda EVM implementation refactor

Comments

@ilitteri
Copy link
Contributor

No description provided.

@ilitteri ilitteri added levm Lambda EVM implementation refactor labels Jan 17, 2025
@varun-doshi
Copy link
Contributor

Just to confirm, do you mean this field name?

ethrex/crates/vm/levm/src/environment.rs

Line 15 in 1926d8b

pub spec_id: SpecId,

@ilitteri
Copy link
Contributor Author

Just to confirm, do you mean this field name?

ethrex/crates/vm/levm/src/environment.rs

Line 15 in 1926d8b
pub spec_id: SpecId,

Yes! And Fork is at crates/common/types/genesis.rs

@varun-doshi varun-doshi mentioned this issue Jan 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 28, 2025
@varun-doshi @lima-limon-inc
@fborello-lambda @lferrigno
refactor(levm): replace specId with Fork (#1762)
69b0e30 
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->

Ref #1741

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->
Replaces specId with Fork
- First change is in file `crates/vm/levm/src/environment.rs`
- - Changes in other relevant files to accept the changes and fix
cascading errors

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes [#1741](#1741)

---------

Co-authored-by: Tomas Fabrizio Orsi <[email protected]>
Co-authored-by: Federico Borello <[email protected]>
Co-authored-by: fborello-lambda <[email protected]>
Co-authored-by: Leandro Ferrigno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
levm Lambda EVM implementation refactor
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(levm): replace specId with Fork varun-doshi/ethrex
2 participants
@varun-doshi @ilitteri