-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l1): implement transaction requests tracker #1801
Open
avilagaston9
wants to merge
9
commits into
main
Choose a base branch
from
l1/feat/track_transaction_requests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we don't have a registry of transaction requests made to other peers using the
GetPooledTransactions
message. As a result, we don't have a way to validate the peers' responses. We may also be requesting the same transaction from multiple peers, consuming more bandwidth.Description
PendingRequests
structure to keep track of requests made.NewPooledTransactionHashes
message, checks if the transactions have not been requested yet.PooledTransactions
response, validates the response against the stored request.PendingRequests
.peer_conn_failed
event, removes the pending requests of the remote_node from the registry.eth/BlobViolations
Hive test: This test sends aPooledTransactions
message with invalid types and sizes. The test was previously passing because the transactions used in the test were also dummy.Additionally, this PR changes how we handle errors when validating the transactions against our mempool before adding them:
Transactions
message, filters and propagates only the valid transactions. This change brakes the Hive testeth/InvalidTxs
since we are incorrectly considering valid two transactions in the test. InvalidTxs #1139 was created to fix this.Closes #1415
Closes #1781
Closes #1416