Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The interface for commit data generation should be reworked #165

Open
mationorato opened this issue Feb 20, 2024 · 0 comments
Open

The interface for commit data generation should be reworked #165

mationorato opened this issue Feb 20, 2024 · 0 comments
Assignees
Labels

Comments

@mationorato
Copy link
Collaborator

Discussion: matter-labs#1015 (comment)

Current implementation spreads across multiple crates and has arguably unexpected design decisions (e.g. structures that were POD before now include behavior). The proposal on how to avoid it is shared.

It’s better to fix it before it becomes a problem since the problems with design are pretty hard to solve once the design decision is implemented.

toni-calvin pushed a commit that referenced this issue Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants