You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
l1_batch_commit_data_generator_mode field in StateKeeperConfig is not marked as Option and has no serde(default) attribute which means that it’s always expected to be set. This means that if this change would be deployed to any existing env without updating configs beforehand, the node will enter the crash loop, because the required configuration option is not present.
Suggestion: Evaluate what makes more sense (Option or serde(default)) and implement it in a backward-compatible way.
The text was updated successfully, but these errors were encountered:
ilitteri
changed the title
make l1_batch_commit_data_generator_mode a mandatory attribute
make l1_batch_commit_data_generator_mode a non-mandatory attribute
Feb 20, 2024
discussion: matter-labs/zksync-era@main...lambdaclass:zksync-era:feat_validium_pubdata_abstraction#diff-1f5da47e2620f95f5ea03f9b1c51c9d7c8a2cfe53c09f2710c7377389dea185dR127
l1_batch_commit_data_generator_mode
field inStateKeeperConfig
is not marked asOption
and has noserde(default)
attribute which means that it’s always expected to be set. This means that if this change would be deployed to any existing env without updating configs beforehand, the node will enter the crash loop, because the required configuration option is not present.Suggestion: Evaluate what makes more sense (
Option
orserde(default)
) and implement it in a backward-compatible way.The text was updated successfully, but these errors were encountered: