Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make l1_batch_commit_data_generator_mode a non-mandatory attribute #168

Open
mationorato opened this issue Feb 20, 2024 · 0 comments · May be fixed by #177
Open

make l1_batch_commit_data_generator_mode a non-mandatory attribute #168

mationorato opened this issue Feb 20, 2024 · 0 comments · May be fixed by #177
Assignees
Labels

Comments

@mationorato
Copy link
Collaborator

discussion: matter-labs/zksync-era@main...lambdaclass:zksync-era:feat_validium_pubdata_abstraction#diff-1f5da47e2620f95f5ea03f9b1c51c9d7c8a2cfe53c09f2710c7377389dea185dR127

l1_batch_commit_data_generator_mode field in StateKeeperConfig is not marked as Option and has no serde(default) attribute which means that it’s always expected to be set. This means that if this change would be deployed to any existing env without updating configs beforehand, the node will enter the crash loop, because the required configuration option is not present.

Suggestion: Evaluate what makes more sense (Option or serde(default)) and implement it in a backward-compatible way.

@ilitteri ilitteri changed the title make l1_batch_commit_data_generator_mode a mandatory attribute make l1_batch_commit_data_generator_mode a non-mandatory attribute Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants