Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracers implementation #243

Closed
wants to merge 25 commits into from
Closed

Conversation

MarcosNicolau
Copy link

@MarcosNicolau MarcosNicolau commented Aug 22, 2024

What ❔

This pr implements tracers for the era_vm. This includes:

  • Create Pubdata, Refunds and Circuits tracers.
  • Create a tracer manager that manages the new tracers and accepts a custom array of tracers to dispatch.
  • Add remaining fields to the ExecutionResult: statistics and metrics collected by the new tracers.
  • Add all remaining tests suites, which support this new features.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@MarcosNicolau MarcosNicolau marked this pull request as ready for review August 22, 2024 21:33
@MarcosNicolau MarcosNicolau marked this pull request as draft August 22, 2024 21:40
@MarcosNicolau MarcosNicolau marked this pull request as ready for review August 26, 2024 13:02
having the result handling in a tracer made the everything very obfuscating
@MarcosNicolau
Copy link
Author

Closing this one, as it is being implemented in #253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant