Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rawurlencode() expects parameter 1 to be string, bool given in Escaper.php:246 #24

Closed
purpletreesoft opened this issue Jun 25, 2021 · 3 comments
Closed

rawurlencode() expects parameter 1 to be string, bool given in Escaper.php:246 #24

purpletreesoft opened this issue Jun 25, 2021 · 3 comments
Labels
BC Break Duplicate This issue or pull request already exists Invalid This doesn't seem right

Comments

@purpletreesoft
Copy link

purpletreesoft commented Jun 25, 2021 •
edited
Loading

The latest version passes int argument to rawurlencode, where string is expected.

problem is at line 246:

return rawurlencode($string);

possible solution:

return rawurlencode(strval($string));
@purpletreesoft
Copy link
Author

This issue was observed in Magento 2 CE, when the latest Laminas was pulled.

@purpletreesoft
Copy link
Author

I see another issue related to strict checks introduced. Perhaps that commit fixes this issue too?

@froschdesign froschdesign added Duplicate This issue or pull request already exists Invalid This doesn't seem right labels Jun 26, 2021
@froschdesign
Copy link
Member

Duplicate of #20

See also: #21 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Duplicate This issue or pull request already exists Invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@froschdesign @purpletreesoft