Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace call_user_func* with self invoked function #34

Closed
michalbundyra opened this issue Jan 15, 2020 · 4 comments · Fixed by #101
Closed

replace call_user_func* with self invoked function #34

michalbundyra opened this issue Jan 15, 2020 · 4 comments · Fixed by #101
Assignees
Milestone

Comments

@michalbundyra
Copy link
Member

as dev-master already use php ^7.1


Originally posted by @samsonasik at zendframework/zend-mail#200

@michalbundyra
Copy link
Member Author

I rolled back the changes on master that changed the PHP minimum, as we are not supposed to do that in a minor release. 2.10.0 will support 5.6 and 7.0 again.

As such, marking this for 3.0.0.


Originally posted by @weierophinney at zendframework/zend-mail#200 (comment)

@michalbundyra
Copy link
Member Author

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Originally posted by @weierophinney at zendframework/zend-mail#200 (comment)

@samsonasik
Copy link
Member

i created PR #101 for it.

Ocramius added a commit that referenced this issue Aug 1, 2020
…nvoke

Fixes #34 replace call_user_func* with self invoked function
@samsonasik
Copy link
Member

closing in favor of #101

@Ocramius Ocramius added this to the 2.13.0 milestone Aug 1, 2020
weierophinney added a commit that referenced this issue Aug 5, 2020
…nvoke

Fixes #34 replace call_user_func* with self invoked function
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this issue May 24, 2023
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this issue May 24, 2023
…-self-invoke

Fixes laminas#34 replace call_user_func* with self invoked function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants