Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Disease source: ordo #128

Open
sunnyosun opened this issue Oct 14, 2024 · 5 comments
Open

Add new Disease source: ordo #128

sunnyosun opened this issue Oct 14, 2024 · 5 comments

Comments

@sunnyosun
Copy link
Member

https://www.ebi.ac.uk/ols4/ontologies/ordo

@Zethson
Copy link
Member

Zethson commented Oct 18, 2024

According to https://mondo.monarchinitiative.org/ a part of mondo.

@matentzn
Copy link

Sorry I am lurking on your project to see how it is developing :)

Mondo nearly fully covers ORDO, OMIM and Disease Ontology as well as a few other identifiers schemes (such as MedGen and UMLS, but also some more partial onces like SNOMED). However, I would prefer to use the term "covers" then "part of". ORDO is not part of Mondo, but Mondo covers ORDO in the sense that, if there is a disease in ORDO, it will exist somewhere in Mondo. There are a handful of disputed correspondences between ORDO and Mondo, but these are being resolved with between Orphanet (ORDO developers) and Monarch (Mondo developers) as we speak.

@Zethson
Copy link
Member

Zethson commented Oct 21, 2024

@matentzn thank you for the details and clarification. It's great to hear that you are resolving these disputes. Thank you for your awesome work with mondo and all of the other ontology related projects that you're contributing to!

@matentzn
Copy link

You are very welcome! And thank you for your kind words!

@sunnyosun
Copy link
Member Author

@Zethson We are filtering with the prefix MONDO: that's why the ordo terms aren't included: https://github.com/laminlabs/bionty/blob/main/bionty/base/entities/_disease.py#L59, we can add the prefix Orphanet: and update the underlying parquet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants