✨ Add more References fields #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
sunnyosun
reviewed
Nov 19, 2024
| """Text of the reference such as the abstract or the full-text to enable search.""" | ||
| description: str = TextField(null=True, default=None) | ||
| """Description of the reference.""" | ||
| authors: list[str] | None = JSONField(null=True, default=None) |
There was a problem hiding this comment.
What will the authors field look like?
There was a problem hiding this comment.
I thought of just having ["firstname lastname, firstname, lastname"] and then populating this field. I did not want to create a whole Authors table just for that.
There was a problem hiding this comment.
Do you mean ["firstname lastname", "firstname lastname"]?
sunnyosun
requested changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for laminlabs/cellxgene. Motivated by the rich output of census collections, we add a few fields to
Referenceto make it more comprehensive. These fields are generally not mandatory.JSONField)DateTimeField)textintoabstract andfull_text`